Branch: refs/heads/feature-deploy-refactor-links
Home: https://github.com/xwiki/xwiki-platform
Commit: c8f33eb3860e809b404b38244c9ba0f41f872861
https://github.com/xwiki/xwiki-platform/commit/c8f33eb3860e809b404b38244c9b…
Author: Simon Urli <simon.urli(a)xwiki.com>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/RenamePageIT.java
M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java
M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/render/DefaultOldRendering.java
M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/XWikiTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/checkstyle/checkstyle-suppressions.xml
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/ReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/ReferenceUpdater.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractCopyOrMoveJob.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractEntityJobWithChecks.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/CopyJob.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/MoveJob.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/listener/BackLinkUpdaterListener.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultMacroRefactoring.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultReferenceUpdater.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultMacroRefactoringTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultReferenceUpdaterTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/ResourceReferenceRenamerTest.java
M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/src/main/java/org/xwiki/rendering/macro/MacroRefactoring.java
Log Message:
-----------
XWIKI-12987: Relative links are made absolute or even broken after moving a page
WIP
The idea of this work is to:
1. Provide a way to access all documents that are moved as part of a
move job
2. Use that information when performing a call to ReferenceRenamer to
define if a relative untyped link should be handled or not
On top of it, the idea is also to check if the doc exists in case of
refactoring of a link to avoid refactoring unexisting relative links.
One problem is remaining about relative link pointing to sibling pages
(e.g. the link to Alice in Bob page in the ticket): we rely apparently
to an old mechanism for backward compatibility reason for this to work
in the UI, we might need same thing in the check, or to decide to
ignore that UC.
I started to add an integration tests but for some reason it's not
passing, though it seemed to be working locally for the scenario
described in the ticket (except for the link in Bob page).
Commit: 456e447a435d0a7994d9e39374de4437a163a713
https://github.com/xwiki/xwiki-platform/commit/456e447a435d0a7994d9e39374de…
Author: Simon Urli <simon.urli(a)xwiki.com>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/RenamePageIT.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-include/src/main/java/org/xwiki/rendering/internal/macro/include/IncludeMacroRefactoring.java
M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-include/src/test/java/org/xwiki/rendering/internal/macro/include/IncludeMacroRefactoringTest.java
Log Message:
-----------
XWIKI-12987: Relative links are made absolute or even broken after moving a page
* Fix integration test setup
* Fix some signatures
* Work on the conditions for performing link update: WIP
Commit: 60c169af60c38aa9c4c4b807ea99732dcb54bf6f
https://github.com/xwiki/xwiki-platform/commit/60c169af60c38aa9c4c4b807ea99…
Author: Simon Urli <simon.urli(a)xwiki.com>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java
Log Message:
-----------
XWIKI-12987: Relative links are made absolute or even broken after moving a page
* Fix conditions to make all RenamePageIT passing
* WIP: need to double check that some conditions are not redundant and
double check side effects
Commit: c8be6ae0a21f77ae8734cba6a1507608c7eb2f0f
https://github.com/xwiki/xwiki-platform/commit/c8be6ae0a21f77ae8734cba6a150…
Author: Simon Urli <simon.urli(a)xwiki.com>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/internal/listener/BackLinkUpdaterListenerTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultReferenceUpdaterTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/ResourceReferenceRenamerTest.java
Log Message:
-----------
XWIKI-12987: Relative links are made absolute or even broken after moving a page
* Simplify a bit the conditions in ResourceReferenceRenamer and ensure
all unit tests are passing in refactoring module
Commit: 4ff12e2ef2683368e79e378849b26cd04fbf7f57
https://github.com/xwiki/xwiki-platform/commit/4ff12e2ef2683368e79e378849b2…
Author: Simon Urli <simon.urli(a)xwiki.com>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/XWikiTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/ReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/ReferenceUpdater.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractEntityJobWithChecks.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/listener/BackLinkUpdaterListener.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultMacroRefactoring.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/src/main/java/org/xwiki/rendering/macro/MacroRefactoring.java
Log Message:
-----------
XWIKI-12987: Relative links are made absolute or even broken after moving a page
* Fix checkstyle
* WIP: try to find proper oracle for renaming absolute references,
without success so far.
Commit: 1ac0e3a439abf2b7302422931298445b4ecaf1a6
https://github.com/xwiki/xwiki-platform/commit/1ac0e3a439abf2b7302422931298…
Author: Simon Urli <simon.urli(a)xwiki.com>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultReferenceUpdaterTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/ResourceReferenceRenamerTest.java
M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-include/src/main/java/org/xwiki/rendering/internal/macro/include/IncludeMacroRefactoring.java
Log Message:
-----------
XWIKI-12987: Relative links are made absolute or even broken after moving a page
* Find proper conditions to perform or not link renames
* Fix unit tests to add missing conditions
* WIP: need to fix coverage and check on subwikis / with more
conditions (e.g. with holes in hierarchy)
Commit: efd557d5c29252854c0c51ab42771c6afd41d056
https://github.com/xwiki/xwiki-platform/commit/efd557d5c29252854c0c51ab4277…
Author: Simon Urli <simon.urli(a)xwiki.com>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/RenamePageIT.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultModelBridgeTest.java
Log Message:
-----------
XWIKI-12987: Relative links are made absolute or even broken after moving a page
* Fix a regression and provide a test to cover it
Commit: 640972309e0fe39b7a4932e0a5901f91d94a96c1
https://github.com/xwiki/xwiki-platform/commit/640972309e0fe39b7a4932e0a590…
Author: Simon Urli <simon.urli(a)xwiki.com>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/RenamePageIT.java
M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-test/xwiki-platform-wiki-test-docker/src/test/it/org/xwiki/wiki/test/ui/SubWikiIT.java
Log Message:
-----------
XWIKI-12987: Relative links are made absolute or even broken after moving a page
* Provide subwiki integration tests
* Minor improvment in RenamePageIT
Commit: 0b077f85cc1eb9bd8cb32e5aebe702b1a3847c65
https://github.com/xwiki/xwiki-platform/commit/0b077f85cc1eb9bd8cb32e5aebe7…
Author: Simon Urli <simon.urli(a)xwiki.com>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-test/xwiki-platform-wiki-test-docker/src/test/it/org/xwiki/wiki/test/ui/SubWikiIT.java
Log Message:
-----------
XWIKI-12987: Relative links are made absolute or even broken after moving a page
* Improve SubWikiIT to add more checks
Commit: 96eb739d9fe782f984fb8f04a0cae3c8074792d2
https://github.com/xwiki/xwiki-platform/commit/96eb739d9fe782f984fb8f04a0ca…
Author: Simon Urli <simon.urli(a)xwiki.com>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/RenamePageIT.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractCopyOrMoveJob.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/CopyJob.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/MoveJob.java
Log Message:
-----------
XWIKI-12987: Relative links are made absolute or even broken after moving a page
* Few improvments following review
Commit: 079bb3cdd1af499332b0be267fd859ddd524a31e
https://github.com/xwiki/xwiki-platform/commit/079bb3cdd1af499332b0be267fd8…
Author: Simon Urli <simon.urli(a)xwiki.com>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java
M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/render/DefaultOldRendering.java
M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/XWikiTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/ReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/ReferenceUpdater.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractCopyOrMoveJob.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractEntityJobWithChecks.java
A xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/InternalCopyOrMoveJobException.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/RenameJob.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/listener/BackLinkUpdaterListener.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/job/question/EntitySelection.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/internal/job/MoveJobTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/internal/job/RenameJobTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/internal/listener/BackLinkUpdaterListenerTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultMacroRefactoring.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultReferenceUpdater.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultMacroRefactoringTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultReferenceUpdaterTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/ResourceReferenceRenamerTest.java
M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-include/src/main/java/org/xwiki/rendering/internal/macro/include/IncludeMacroRefactoring.java
M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-include/src/test/java/org/xwiki/rendering/internal/macro/include/IncludeMacroRefactoringTest.java
M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/src/main/java/org/xwiki/rendering/macro/MacroRefactoring.java
Log Message:
-----------
XWIKI-12987: Relative links are made absolute or even broken after moving a page
* Change APIs to use a Map<EntityReference, EntityReference>
corresponding to the source and target of refactorings in renamers
* Change some logic of AbstractCopyOrMoveJob to compute the actual
couple source/destination before performing any operation and store
the info in EntitySelection
* Add a log in RenameJob if it's not executed because of the number of
entities (not needed for this issue, but felt better to understand
what's happening)
Commit: 1d8b51bfcace93f68fa33fc1bc22fcac67d1aa9f
https://github.com/xwiki/xwiki-platform/commit/1d8b51bfcace93f68fa33fc1bc22…
Author: Simon Urli <simon.urli(a)xwiki.com>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultModelBridgeTest.java
M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-include/src/test/java/org/xwiki/rendering/internal/macro/include/IncludeMacroRefactoringTest.java
Log Message:
-----------
XWIKI-12987: Relative links are made absolute or even broken after moving a page
* Fix remaining coverage problems
Compare: https://github.com/xwiki/xwiki-platform/compare/c8f33eb3860e%5E...1d8b51bfc…
To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications
Branch: refs/heads/XWIKI-12987
Home: https://github.com/xwiki/xwiki-platform
Commit: c8f33eb3860e809b404b38244c9ba0f41f872861
https://github.com/xwiki/xwiki-platform/commit/c8f33eb3860e809b404b38244c9b…
Author: Simon Urli <simon.urli(a)xwiki.com>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/RenamePageIT.java
M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java
M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/render/DefaultOldRendering.java
M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/XWikiTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/checkstyle/checkstyle-suppressions.xml
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/ReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/ReferenceUpdater.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractCopyOrMoveJob.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractEntityJobWithChecks.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/CopyJob.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/MoveJob.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/listener/BackLinkUpdaterListener.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultMacroRefactoring.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultReferenceUpdater.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultMacroRefactoringTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultReferenceUpdaterTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/ResourceReferenceRenamerTest.java
M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/src/main/java/org/xwiki/rendering/macro/MacroRefactoring.java
Log Message:
-----------
XWIKI-12987: Relative links are made absolute or even broken after moving a page
WIP
The idea of this work is to:
1. Provide a way to access all documents that are moved as part of a
move job
2. Use that information when performing a call to ReferenceRenamer to
define if a relative untyped link should be handled or not
On top of it, the idea is also to check if the doc exists in case of
refactoring of a link to avoid refactoring unexisting relative links.
One problem is remaining about relative link pointing to sibling pages
(e.g. the link to Alice in Bob page in the ticket): we rely apparently
to an old mechanism for backward compatibility reason for this to work
in the UI, we might need same thing in the check, or to decide to
ignore that UC.
I started to add an integration tests but for some reason it's not
passing, though it seemed to be working locally for the scenario
described in the ticket (except for the link in Bob page).
Commit: 456e447a435d0a7994d9e39374de4437a163a713
https://github.com/xwiki/xwiki-platform/commit/456e447a435d0a7994d9e39374de…
Author: Simon Urli <simon.urli(a)xwiki.com>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/RenamePageIT.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-include/src/main/java/org/xwiki/rendering/internal/macro/include/IncludeMacroRefactoring.java
M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-include/src/test/java/org/xwiki/rendering/internal/macro/include/IncludeMacroRefactoringTest.java
Log Message:
-----------
XWIKI-12987: Relative links are made absolute or even broken after moving a page
* Fix integration test setup
* Fix some signatures
* Work on the conditions for performing link update: WIP
Commit: 60c169af60c38aa9c4c4b807ea99732dcb54bf6f
https://github.com/xwiki/xwiki-platform/commit/60c169af60c38aa9c4c4b807ea99…
Author: Simon Urli <simon.urli(a)xwiki.com>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java
Log Message:
-----------
XWIKI-12987: Relative links are made absolute or even broken after moving a page
* Fix conditions to make all RenamePageIT passing
* WIP: need to double check that some conditions are not redundant and
double check side effects
Commit: c8be6ae0a21f77ae8734cba6a1507608c7eb2f0f
https://github.com/xwiki/xwiki-platform/commit/c8be6ae0a21f77ae8734cba6a150…
Author: Simon Urli <simon.urli(a)xwiki.com>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/internal/listener/BackLinkUpdaterListenerTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultReferenceUpdaterTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/ResourceReferenceRenamerTest.java
Log Message:
-----------
XWIKI-12987: Relative links are made absolute or even broken after moving a page
* Simplify a bit the conditions in ResourceReferenceRenamer and ensure
all unit tests are passing in refactoring module
Commit: 4ff12e2ef2683368e79e378849b26cd04fbf7f57
https://github.com/xwiki/xwiki-platform/commit/4ff12e2ef2683368e79e378849b2…
Author: Simon Urli <simon.urli(a)xwiki.com>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/XWikiTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/ReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/ReferenceUpdater.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractEntityJobWithChecks.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/listener/BackLinkUpdaterListener.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultMacroRefactoring.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/src/main/java/org/xwiki/rendering/macro/MacroRefactoring.java
Log Message:
-----------
XWIKI-12987: Relative links are made absolute or even broken after moving a page
* Fix checkstyle
* WIP: try to find proper oracle for renaming absolute references,
without success so far.
Commit: 1ac0e3a439abf2b7302422931298445b4ecaf1a6
https://github.com/xwiki/xwiki-platform/commit/1ac0e3a439abf2b7302422931298…
Author: Simon Urli <simon.urli(a)xwiki.com>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultReferenceUpdaterTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/ResourceReferenceRenamerTest.java
M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-include/src/main/java/org/xwiki/rendering/internal/macro/include/IncludeMacroRefactoring.java
Log Message:
-----------
XWIKI-12987: Relative links are made absolute or even broken after moving a page
* Find proper conditions to perform or not link renames
* Fix unit tests to add missing conditions
* WIP: need to fix coverage and check on subwikis / with more
conditions (e.g. with holes in hierarchy)
Commit: efd557d5c29252854c0c51ab42771c6afd41d056
https://github.com/xwiki/xwiki-platform/commit/efd557d5c29252854c0c51ab4277…
Author: Simon Urli <simon.urli(a)xwiki.com>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/RenamePageIT.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultModelBridgeTest.java
Log Message:
-----------
XWIKI-12987: Relative links are made absolute or even broken after moving a page
* Fix a regression and provide a test to cover it
Commit: 640972309e0fe39b7a4932e0a5901f91d94a96c1
https://github.com/xwiki/xwiki-platform/commit/640972309e0fe39b7a4932e0a590…
Author: Simon Urli <simon.urli(a)xwiki.com>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/RenamePageIT.java
M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-test/xwiki-platform-wiki-test-docker/src/test/it/org/xwiki/wiki/test/ui/SubWikiIT.java
Log Message:
-----------
XWIKI-12987: Relative links are made absolute or even broken after moving a page
* Provide subwiki integration tests
* Minor improvment in RenamePageIT
Commit: 0b077f85cc1eb9bd8cb32e5aebe702b1a3847c65
https://github.com/xwiki/xwiki-platform/commit/0b077f85cc1eb9bd8cb32e5aebe7…
Author: Simon Urli <simon.urli(a)xwiki.com>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-test/xwiki-platform-wiki-test-docker/src/test/it/org/xwiki/wiki/test/ui/SubWikiIT.java
Log Message:
-----------
XWIKI-12987: Relative links are made absolute or even broken after moving a page
* Improve SubWikiIT to add more checks
Commit: 96eb739d9fe782f984fb8f04a0cae3c8074792d2
https://github.com/xwiki/xwiki-platform/commit/96eb739d9fe782f984fb8f04a0ca…
Author: Simon Urli <simon.urli(a)xwiki.com>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/RenamePageIT.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractCopyOrMoveJob.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/CopyJob.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/MoveJob.java
Log Message:
-----------
XWIKI-12987: Relative links are made absolute or even broken after moving a page
* Few improvments following review
Commit: 079bb3cdd1af499332b0be267fd859ddd524a31e
https://github.com/xwiki/xwiki-platform/commit/079bb3cdd1af499332b0be267fd8…
Author: Simon Urli <simon.urli(a)xwiki.com>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java
M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/render/DefaultOldRendering.java
M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/XWikiTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/ReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/ReferenceUpdater.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractCopyOrMoveJob.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractEntityJobWithChecks.java
A xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/InternalCopyOrMoveJobException.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/RenameJob.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/listener/BackLinkUpdaterListener.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/job/question/EntitySelection.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/internal/job/MoveJobTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/internal/job/RenameJobTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/internal/listener/BackLinkUpdaterListenerTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultMacroRefactoring.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultReferenceUpdater.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultMacroRefactoringTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultReferenceUpdaterTest.java
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/ResourceReferenceRenamerTest.java
M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-include/src/main/java/org/xwiki/rendering/internal/macro/include/IncludeMacroRefactoring.java
M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-include/src/test/java/org/xwiki/rendering/internal/macro/include/IncludeMacroRefactoringTest.java
M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/src/main/java/org/xwiki/rendering/macro/MacroRefactoring.java
Log Message:
-----------
XWIKI-12987: Relative links are made absolute or even broken after moving a page
* Change APIs to use a Map<EntityReference, EntityReference>
corresponding to the source and target of refactorings in renamers
* Change some logic of AbstractCopyOrMoveJob to compute the actual
couple source/destination before performing any operation and store
the info in EntitySelection
* Add a log in RenameJob if it's not executed because of the number of
entities (not needed for this issue, but felt better to understand
what's happening)
Commit: 1d8b51bfcace93f68fa33fc1bc22fcac67d1aa9f
https://github.com/xwiki/xwiki-platform/commit/1d8b51bfcace93f68fa33fc1bc22…
Author: Simon Urli <simon.urli(a)xwiki.com>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultModelBridgeTest.java
M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-include/src/test/java/org/xwiki/rendering/internal/macro/include/IncludeMacroRefactoringTest.java
Log Message:
-----------
XWIKI-12987: Relative links are made absolute or even broken after moving a page
* Fix remaining coverage problems
Compare: https://github.com/xwiki/xwiki-platform/compare/7bb0a615e654...1d8b51bfcace
To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications
Branch: refs/heads/CRISTAL-142
Home: https://github.com/xwiki-contrib/cristal
Commit: 9ac3b6090b9927ab1e3f51d8f7ddcb12a1da6099
https://github.com/xwiki-contrib/cristal/commit/9ac3b6090b9927ab1e3f51d8f7d…
Author: Pierre Jeanjean <pierre.jeanjean(a)xwiki.com>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M api/src/api/PageData.ts
M api/src/api/cristalApp.ts
M api/src/api/storage.ts
M core/alerts/alerts-ui/src/vue/AlertsToasts.vue
M core/backends/backend-api/src/abstractStorage.ts
M core/backends/backend-dexie/src/wrappingOfflineStorage.ts
M core/backends/backend-github/src/githubStorage.ts
M core/backends/backend-xwiki/package.json
M core/backends/backend-xwiki/src/xwikiStorage.ts
M core/document/document-api/src/index.ts
M core/document/document-default/src/defaultDocumentService.ts
M core/hierarchy/hierarchy-default/src/utils.ts
M core/hierarchy/hierarchy-xwiki/package.json
R core/hierarchy/hierarchy-xwiki/src/__tests__/utils.test.ts
M core/hierarchy/hierarchy-xwiki/src/components/componentsInit.ts
R core/hierarchy/hierarchy-xwiki/src/utils.ts
R core/hierarchy/hierarchy-xwiki/vitest.config.ts
A core/history/history-api/package.json
A core/history/history-api/src/index.ts
A core/history/history-api/tsconfig.json
A core/history/history-api/tsdoc.json
A core/history/history-api/vite.config.ts
A core/history/history-default/package.json
A core/history/history-default/src/components/componentsInit.ts
A core/history/history-default/src/index.ts
A core/history/history-default/tsconfig.json
A core/history/history-default/tsdoc.json
A core/history/history-default/vite.config.ts
A core/history/history-github/package.json
A core/history/history-github/src/components/componentsInit.ts
A core/history/history-github/src/index.ts
A core/history/history-github/tsconfig.json
A core/history/history-github/tsdoc.json
A core/history/history-github/vite.config.ts
A core/history/history-ui/langs/translation-en.json
A core/history/history-ui/langs/translation-fr.json
A core/history/history-ui/package.json
A core/history/history-ui/src/HistoryExtraTab.ts
A core/history/history-ui/src/index.ts
A core/history/history-ui/src/translations.ts
A core/history/history-ui/src/vue/HistoryTab.vue
A core/history/history-ui/tsconfig.json
A core/history/history-ui/tsdoc.json
A core/history/history-ui/vite.config.ts
A core/history/history-xwiki/package.json
A core/history/history-xwiki/src/components/componentsInit.ts
A core/history/history-xwiki/src/index.ts
A core/history/history-xwiki/tsconfig.json
A core/history/history-xwiki/tsdoc.json
A core/history/history-xwiki/vite.config.ts
M core/navigation-tree/navigation-tree-filesystem/src/components/componentsInit.ts
M core/navigation-tree/navigation-tree-nextcloud/src/components/componentsInit.ts
M core/page-actions/page-actions-ui/src/vue/PageActions.vue
A core/xwiki/xwiki-utils/package.json
A core/xwiki/xwiki-utils/src/__tests__/utils.test.ts
A core/xwiki/xwiki-utils/src/index.ts
A core/xwiki/xwiki-utils/tsconfig.json
A core/xwiki/xwiki-utils/tsdoc.json
A core/xwiki/xwiki-utils/vite.config.ts
A core/xwiki/xwiki-utils/vitest.config.ts
M ds/api/src/index.ts
M ds/shoelace/src/vue/x-alert.vue
M ds/vuetify/src/vue/x-alert.vue
M lib/package.json
M lib/src/components/DefaultCristalApp.ts
M lib/src/staticBuild.ts
M pnpm-lock.yaml
M pnpm-workspace.yaml
M skin/langs/translation-en.json
M skin/langs/translation-fr.json
M skin/src/vue/c-content.vue
M sources/xwiki/mock-server/src/index.ts
M web/e2e/main-page.spec.ts
A web/e2e/pageObjects/HistoryExtraTab.ts
M web/package.json
M web/src/index.ts
Log Message:
-----------
CRISTAL-142: View history if the backend supports it
* Add components `PageRevisionManager` and `PageRevisionManagerProvider`
* Add implementation for XWiki and GitHub
* Add History extra tab
* Disable edit operations and display alert when user is browsing a
specific revision
* Create utility module `cristal-xwiki-utils`
* Add UI test
To unsubscribe from these emails, change your notification settings at https://github.com/xwiki-contrib/cristal/settings/notifications