There is 1 update, 2 comments.
 
 
XWiki Platform / cid:jira-generated-image-avatar-c930c8d3-38d0-4cd9-8e36-73d44fdb823f XWIKI-22496 Open

Link dialog option button is not keyboard operable

 
View issue   ยท   Add comment
 

1 update

 
cid:jira-generated-image-avatar-fea02837-490f-468d-9920-24d7e8152c3a Changes by Charpentier Lucas on 05/Dec/24 13:46
 
Attachment: screenshot-1.png
 
 

2 comments

 
cid:jira-generated-image-avatar-fea02837-490f-468d-9920-24d7e8152c3a Charpentier Lucas on 05/Dec/24 13:43
 

Started a PR at https://github.com/xwiki/xwiki-platform/pull/3714

 
cid:jira-generated-image-avatar-fea02837-490f-468d-9920-24d7e8152c3a Charpentier Lucas on 05/Dec/24 13:46
 

Some notes I took while looking for a solution:
infoTab.add -> https://github.com/ckeditor/ckeditor4/blob/82796d03d0ebbe34d48f3b65c6dde27107812a51/plugins/dialog/plugin.js#L2046 returns [CKEDITOR.dialog.definition.uiElement](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_dialog_definition_uiElement.html) !== [CKEDITOR.ui.dialog.uiElement](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_ui_dialog_uiElement.html)
addFocusable -> https://github.com/ckeditor/ckeditor4/blob/82796d03d0ebbe34d48f3b65c6dde27107812a51/plugins/dialog/plugin.js#L1491 takes argument CKEditor.DOM.Element

CKEDITOR.ui.dialog.uiElement . getElement() --> CKEditor.DOM.Element

___

Using the button event type did not work, tried with things like:
return {
id: 'optionsToggle',
type: 'button',
className: 'linkOptionsToggle',
label: '<span class="arrow arrow-right"></span> ' +
CKEDITOR.tools.htmlEncode(editor.localization.get('xwiki-link.options')),

___
Click triggered twice when pressing keyboard:

_thumb_42990.png

https://github.com/ckeditor/ckeditor4/blob/82796d03d0ebbe34d48f3b65c6dde27107812a51/plugins/dialog/plugin.js#L710-L713 weird keyboard listener sending an extra click event...