25 Jan
2025
25 Jan
'25
8:24 p.m.
Branch: refs/heads/master
Home: https://github.com/xwiki/xwiki-platform
Commit: e29b630b2d5a42b6f12ed3f0e4f59bd078f8a0f7
https://github.com/xwiki/xwiki-platform/commit/e29b630b2d5a42b6f12ed3f0e4f5…
Author: Marius Dumitru Florea <marius(a)xwiki.com>
Date: 2025-01-25 (Sat, 25 Jan 2025)
Changed paths:
M
xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-plugins/src/main/webjar/xwiki-macro/plugin.js
M
xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-plugins/src/main/webjar/xwiki-realtime/ckeditorRealtimeAdapter.js
M
xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-plugins/src/main/webjar/xwiki-realtime/plugin.js
A
xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-plugins/src/main/webjar/xwiki-selection/diffWorker.js
M
xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-plugins/src/main/webjar/xwiki-selection/plugin.js
M
xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-plugins/src/main/webjar/xwiki-source/plugin.js
M
xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-plugins/src/test/javascript/testUtils.js
M
xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-plugins/src/test/javascript/xwiki-selection.js
M
xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-plugins/src/test/javascript/xwiki-source.js
M
xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-plugins/src/test/resources/jasmine-require-config.txt
M
xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-ui/src/main/resources/CKEditor/Translations.xml
M
xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-wysiwyg/xwiki-platform-realtime-wysiwyg-webjar/src/main/webjar/editor.js
M
xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-wysiwyg/xwiki-platform-realtime-wysiwyg-webjar/src/main/webjar/patches.js
Log Message:
-----------
XWIKI-21224: Performance issue when clicking the view source button in the WYSIWYG
editor
* Move the diff computation in a Web Worker (shared by all CKEditor instances on the same
page)
* Update the code to take into account that restoring the selection is now an asynchronous
process.
* Show a progress notification message after 1s that can be used to abort the selection
restore
* Use a simple fake progress based on an exponential function that goes towards 100% but
never reaches it
* Fix jasmine tests
(cherry picked from commit 33efc2f73a4990acf9ab045b4c6b378910b9ed53)
Commit: 20d352276c008c8ea2a1cf1ea9ceb84193098477
https://github.com/xwiki/xwiki-platform/commit/20d352276c008c8ea2a1cf1ea9ce…
Author: Marius Dumitru Florea <marius(a)xwiki.com>
Date: 2025-01-25 (Sat, 25 Jan 2025)
Changed paths:
M
xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-plugins/src/main/webjar/xwiki-selection/plugin.js
M
xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-wysiwyg/xwiki-platform-realtime-wysiwyg-webjar/src/main/webjar/wysiwygEditor.js
Log Message:
-----------
XWIKI-21224: Performance issue when click the view source button in the WYSIWYG editor
* Pause the realtime synchronization while the selection is being restored (asynchronously
in a Web Worker)
* If the visible content changes (e.g. mouse hover activates some CSS rules that toggle
the visibiity of some part of the content, such as the image resize handles) while the
selection is being restored (i.e. while the Web Worker computes the diff) we need to redo
the transformation (i.e. redo the diff, until the the content remains unchanged).
(cherry picked from commit a8fcc8dd5c4a567f4b6096d5bf2cc980c5247f1b)
Compare: https://github.com/xwiki/xwiki-platform/compare/023144daf732...20d352276c00
To unsubscribe from these emails, change your notification settings at
https://github.com/xwiki/xwiki-platform/settings/notifications