This issue has been created
There is 1 update.
 
 
XWiki Platform / cid:jira-generated-image-avatar-ef88a965-ea22-476c-a909-8171dbc11687 XWIKI-22213 Open

Possible "Illegal char : at index 4: wiki:" when displaying a job log on Windows
 
View issue   ยท   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-62008cf7-93ed-49dd-98c1-315f37366db6 Thomas Mortagne created this issue on 06/Jun/24 10:32
 
Summary: Possible "Illegal char <:> at index 4: wiki:" when displaying a job log on Windows
Issue Type: cid:jira-generated-image-avatar-ef88a965-ea22-476c-a909-8171dbc11687 Bug
Affects Versions: 4.5.1
Assignee: Unassigned
Components: Web - Templates & Resources
Created: 06/Jun/24 10:32
Priority: cid:jira-generated-image-static-critical-a653832c-0597-4185-b7a8-93cb10a41667 Critical
Reporter: Thomas Mortagne
Description:

The [job log displayer](https://github.com/xwiki/xwiki-platform/blob/dfba8556a4f8ff9b167ba4e4034e16195fd97d0a/xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/logging_macros.vm#L120) is doing

$argument.startsWith('wiki:')

assuming that if it's not a String it will just get false.

Problem is that if this argument is a Path and the system is Windows this line will crash the script...

We need to make this code a little safer.
 
 

1 update

 
cid:jira-generated-image-avatar-62008cf7-93ed-49dd-98c1-315f37366db6 Changes by Thomas Mortagne on 06/Jun/24 10:34
 
Summary: Possible "Illegal char < : > at index 4: wiki:" when displaying a job log on Windows
 
 
This message was sent by Atlassian Jira (v9.3.0#930000-sha1:287aeb6) Atlassian logo
If image attachments aren't displayed, see this article.