[xwiki-notifications] [xwiki/xwiki-platform] bfd2b4: XWIKI-21988: Page naming strategy is blocking crea...

Branch: refs/heads/XWIKI-21988 Home: https://github.com/xwiki/xwiki-platform Commit: bfd2b464585a274df662cf2b0efe6d6ec9f9c8af https://github.com/xwiki/xwiki-platform/commit/bfd2b464585a274df662cf2b0efe… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-06-25 (Tue, 25 Jun 2024) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/CreateAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/CreateActionRequestHandler.java M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/createinline.vm M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/js/xwiki/create.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/js/xwiki/xwiki.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/widgets/select/select.js Log Message: ----------- XWIKI-21988: Page naming strategy is blocking creation of pages not respecting it The goal here is to immediately display a feedback in the create page dialog telling the user that the reference is wrong before they click on create. I performed following changes here: * Refactor CreateActionRequestHandler to have a clean separation between retrieving the reference and performing checks over templates * Refactor a bit CreateAction to perform immediate checks over the rights and the name strategy before even checking if the template is chosen: the goal being here to immediately provide exception if there's a problem * Refactor createinline.vm to inject bootstrap modal html elements when used with an ajax request: the idea here is to display an ajax modal instead of the old deprecated xwiki dialog * Refactor xwiki.js to use a jquery ajax call to request and display createinline * Add listener on xwiki:dom:updated events in both create.js and select.js to properly load them in case of dom updates Some work is still needed to display a better information message to the user, in particular about the strategy that should be used. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications