| The manual test is here: Switch between Icon Themes. Matrix discussion: https://matrix.to/#/!ikPtGZaGWtyblizzlR:matrix.xwiki.com/$1729159113821HCVxQ:matrix.xwiki.com?via=matrix.org&via=matrix.xwiki.com&via=mtrx.nz Lucas Charpentier: Ilie Andriuta: Hi! Continuing the manual tests migration, there is a test about checking if switching between Icon Themes from Administration works properly: https://test.xwiki.org/xwiki/bin/view/Administration%20Tests/Switch%20between%20Icon%20Themes. I've checked https://github.com/xwiki/xwiki-platform/blob/aa181b9c5d1417e04b6dce5cec1a3cfea025b250/xwiki-platform-core/xwiki-platform-icon/xwiki-platform-icon-test/xwiki-platform-icon-test-docker/src/test/it/org/xwiki/icon/test/ui/IconThemesRestIT.java but I don't know for sure if automated tests exist. Can you please confirm? Thanks! For what I understand, the file you linked to is testing the REST API, which is a bit more backend than the manual test you shared.
I would have expected a test for this feature in xwiki-core/xwiki-administration. Here is the quick search I did:
https://github.com/search?q=repo%253Axwiki%252Fxwiki-platform+path%253A%252F%5Exwiki-platform-core%5C%252Fxwiki-platform-administration%5C%252F%252F+icon&type=code
All I could find that looked somewhat relevant is https://github.com/xwiki/xwiki-platform/blame/aa181b9c5d1417e04b6dce5cec1a3cfea025b250/xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-test/xwiki-platform-administration-test-pageobjects/src/main/java/org/xwiki/administration/test/po/ThemesAdministrationSectionPage.java#L45 but it seems like this is a typo and this is only to test color themes (!= icon themes) ...
Looking a bit more into the functions of this pageObject, there's nothing about icons. There would be something if it was tested anywhere I didn't check. Unless we duplicated the pageObject (which I doubt happened), I can confirm that there's no automated test for this UI yet. Ilie Andriuta: Thanks, Lucas, I will create a task for it! |
