This issue has been created
There are 4 updates.
 
 
Confluence / cid:jira-generated-image-avatar-a2b2af45-e5ee-4f97-8b9a-7f23f39478d7 CONFLUENCE-247 Closed

Don't completely fail when unable to determine parent object type
 
View issue   ·   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-41bba302-43d6-40fe-b09f-1baaf60b2bf6 Raphaël Jakse created this issue on 05/Jun/24 10:19
 
Summary: Don't completely fail when unable to determine parent object type
Issue Type: cid:jira-generated-image-avatar-a2b2af45-e5ee-4f97-8b9a-7f23f39478d7 Improvement
Affects Versions: 9.47.1
Assignee: Unassigned
Components: XML
Created: 05/Jun/24 10:19
Priority: cid:jira-generated-image-static-major-d3882858-9bf2-48d3-9f82-5130d56bc4be Major
Reporter: Raphaël Jakse
Description:

We got the following trace. We shouldn't completely fail and let the package import keep going. Instead, we should complain loudly (that's indeed a clue that we don't support something, and that something might be critical... or not).
We also need to know the object type that's failing so we can further improve the code and handle this type, so let's add the information to the error message. We will also print the id of the related object so we can ask crafty user extracts of their entitites.xml fails if they don't want to send the whole thing for privacy reasons.

org.xwiki.filter.FilterException: Failed to read package
	at org.xwiki.contrib.confluence.filter.internal.input.ConfluenceInputFilterStream.readInternal(ConfluenceInputFilterStream.java:319)
	at org.xwiki.contrib.confluence.filter.internal.input.ConfluenceInputFilterStream.read(ConfluenceInputFilterStream.java:198)
	at org.xwiki.contrib.confluence.filter.internal.input.ConfluenceInputFilterStream.read(ConfluenceInputFilterStream.java:100)
	at org.xwiki.filter.input.AbstractBeanInputFilterStream.read(AbstractBeanInputFilterStream.java:79)
	at org.xwiki.filter.internal.job.FilterStreamConverterJob.runInternal(FilterStreamConverterJob.java:97)
	at org.xwiki.job.AbstractJob.runInContext(AbstractJob.java:246)
	at org.xwiki.job.AbstractJob.run(AbstractJob.java:223)
	at org.xwiki.filter.script.internal.ScriptFilterStreamConverterJob.run(ScriptFilterStreamConverterJob.java:75)
	at com.xwiki.confluencepro.internal.ConfluenceMigrationJob.runInternal(ConfluenceMigrationJob.java:165)
	at org.xwiki.job.AbstractJob.runInContext(AbstractJob.java:246)
	at org.xwiki.job.AbstractJob.run(AbstractJob.java:223)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)
Caused by: org.xwiki.filter.FilterException: Failed to analyze the package index
	at org.xwiki.contrib.confluence.filter.input.ConfluenceXMLPackage.read(ConfluenceXMLPackage.java:846)
	at org.xwiki.contrib.confluence.filter.internal.input.ConfluenceInputFilterStream.readInternal(ConfluenceInputFilterStream.java:310)
	... 13 more
Caused by: org.xwiki.filter.FilterException: Unexpected object type. This is a bug in confluence-xml, please report.
	at org.xwiki.contrib.confluence.filter.input.ConfluenceXMLPackage.getObjectByType(ConfluenceXMLPackage.java:1464)
	at org.xwiki.contrib.confluence.filter.input.ConfluenceXMLPackage.readBodyContentObject(ConfluenceXMLPackage.java:1579)
	at org.xwiki.contrib.confluence.filter.input.ConfluenceXMLPackage.readObject(ConfluenceXMLPackage.java:1327)
	at org.xwiki.contrib.confluence.filter.input.ConfluenceXMLPackage.createTree(ConfluenceXMLPackage.java:1260)
	at org.xwiki.contrib.confluence.filter.input.ConfluenceXMLPackage.read(ConfluenceXMLPackage.java:844)
	... 14 more
 
 

4 updates

 
cid:jira-generated-image-avatar-41bba302-43d6-40fe-b09f-1baaf60b2bf6 Changes by Raphaël Jakse on 05/Jun/24 10:22
 
Fix Version: 9.47.2
Assignee: Raphaël Jakse
Resolution: Fixed
Status: Open Closed
 
 
This message was sent by Atlassian Jira (v9.3.0#930000-sha1:287aeb6) Atlassian logo
If image attachments aren't displayed, see this article.