This issue has been created
There are 3 updates.
 
 
XWiki Platform / cid:jira-generated-image-avatar-0969b86c-cc3d-4bce-8157-0e5a94c5c695 XWIKI-22216 Open

Refactoring jobs don't take into account well known types of macro parameters

 
View issue   ยท   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-ed80b27a-ba7c-45e1-9137-db8b1333c6b8 Thomas Mortagne created this issue on 07/Jun/24 14:15
 
Summary: Refactoring jobs don't take into well know types macro parameters
Issue Type: cid:jira-generated-image-avatar-0969b86c-cc3d-4bce-8157-0e5a94c5c695 Improvement
Affects Versions: 8.4
Assignee: Unassigned
Components: Refactoring
Created: 07/Jun/24 14:15
Priority: cid:jira-generated-image-static-major-9a806f74-6a91-419e-b403-f3cfc10fed7a Major
Reporter: Thomas Mortagne
Description:

XWIKI-14672 added support for macro content (only type wiki), and it's relying on an API that would allow to converter parameters too (and we do for include and display macro specifically) but we never implemented it.

It should not be too hard to cover the following types:

  • all forms of EntityReference (DocumentReference, etc.)
  • MacroContentSourceReference of type related to entities
 
 

3 updates

 
cid:jira-generated-image-avatar-ed80b27a-ba7c-45e1-9137-db8b1333c6b8 Changes by Thomas Mortagne on 07/Jun/24 14:15
 
Summary: Refactoring jobs don't take into well know known types of macro parameters
 
cid:jira-generated-image-avatar-2b67e474-d6ed-42d3-a5d8-fdecf3da402a Changes by Michael Hamann on 07/Jun/24 14:17
 
Summary: Refactoring jobs don't take into account well known types of macro parameters
 
cid:jira-generated-image-avatar-ed80b27a-ba7c-45e1-9137-db8b1333c6b8 Changes by Thomas Mortagne on 07/Jun/24 14:18
 
Description: XWIKI-14672 added support for macro content (only type wiki), and it's relying on an API that would allow to converter parameters too (and we do for include and display macro specifically) but we never implemented it.

It should not be too hard to cover the following types:
* all forms of EntityReference (DocumentReference, etc.)
* MacroContentSourceReference of type related to entities


The best would probably be interesting to introduce some new MacroParameterRefactoring called by DefaultMacroRefactoring to make easier to add support for a new type of parameter.