There are 2 comments.
 
 
XWiki Platform / cid:jira-generated-image-avatar-a65b6f65-7285-4ee5-a2f6-521442daadb8 XWIKI-21705 Open

Propose a dark theme

 
View issue   ยท   Add comment
 

2 comments

 
cid:jira-generated-image-avatar-9ef250c1-b113-408f-92fb-ac3620fad28f Charpentier Lucas on 02/Oct/24 15:55
 

https://github.com/xwiki/xwiki-platform/blob/7b3680f01da34b632c04524668cfda2f35a43360/xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-skinx/src/main/java/com/xpn/xwiki/plugin/skinx/CssSkinExtensionPlugin.java#L87

-> the code that creates the link tags for skin extensions. We could duplicate it to give both color themes.

 

https://github.com/xwiki/xwiki-platform/blob/3746464546e01f2f1fd468f922e754c01800e44a/xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-ui/src/main/resources/CKEditor/InlineEditor.xml#L141-L148 Sometimes css will be loaded directly from javascript. We need a solution so that the CSS loaded like this uses the correct color theme.

 
cid:jira-generated-image-avatar-9ef250c1-b113-408f-92fb-ac3620fad28f Charpentier Lucas on 02/Oct/24 15:57
 

Nikita Petrenko 

It would mean that each user individually has the choice between a light and a dark theme.

The admin still controls what are those themes but this means that the interface could be radically different between two users.

 

Note that the admin can already set a dark theme on its wiki. We don't have a good support for any of them yet though (at least not as good as Iceberg).