This issue has been created
 
 
XWiki Platform / cid:jira-generated-image-avatar-efd8791a-c19f-4b29-aa3f-f68358d0722f XWIKI-22893 Open

Improve consistency of global LESS variable declaration in Flamingo

 
View issue   ยท   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-8dc88cc3-4a81-4c20-a87d-4e3d873cdaf8 Charpentier Lucas created this issue on 19/Feb/25 14:27
 
Summary: Improve consistency of global LESS variable declaration in Flamingo
Issue Type: cid:jira-generated-image-avatar-efd8791a-c19f-4b29-aa3f-f68358d0722f Improvement
Affects Versions: 17.1.0-rc-1
Assignee: Unassigned
Components: Flamingo Skin
Created: 19/Feb/25 14:27
Labels: consistency
Priority: cid:jira-generated-image-static-minor-70087920-b434-4794-9d26-2309ae901bdf Minor
Reporter: Charpentier Lucas
Description:

All the XWiki specific variables should be defined in variables.less . Other LESS files should only contain styles in themselves.

In addition, the variable `@loginFormMaxWidth` should be renamed because it did not respect our naming convention (strictly speaking we don't have one for naming LESS variables, but we have one for HTML/CSS classes and bootstrap had one that we followed for pretty much all other variables). This is technically a backward compatibility break, but the name and use of this variable is so niche that I doubt anyone used it in a customization...