There are 2 updates, 1 comment.
 
 
Change Request Application / cid:jira-generated-image-avatar-a645916b-4b16-426d-a1cd-7c8243047d90 CRAPP-365 Open

Velocity error preventing to access a change request

 
View issue   ยท   Add comment
 

2 updates

 
cid:jira-generated-image-avatar-24dea314-e91c-489c-bfba-09bdc3cce3fc Changes by Simon Urli on 02/Jun/25 10:44
 
Description: No reproduction step found yet. Reproduction steps:
  * Create a page named "Foo"
  * Create another page with a link to Foo and an include macro referencing Foo
  * Edit that page and create a change request just before the inserting link
  * Add a new comment in the diff on the include macro (the 3 diff lines should include both the include and the link)
  * Rename the page Foo

  * Check back the change request

Expected result:
  * The change request should be displayed fine and the comment should still be visible

Obtained result:
* The change request isn't visible anymore and a velocity error is displayed

Apparently a change request in xwiki.org is not visible anymore, a velocity error is displayed, with an error.

The root cause seems to be:
{noformat}
Caused by: com.fasterxml.jackson.core.JsonParseException: Unexpected character ('\' (code 92)): was expecting comma to separate Object entries
at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 1, column: 285]
at com.fasterxml.jackson.core.JsonParser._constructReadException(JsonParser.java:2660)
at com.fasterxml.jackson.core.base.ParserMinimalBase._reportUnexpectedChar(ParserMinimalBase.java:741)
at com.fasterxml.jackson.core.json.ReaderBasedJsonParser._skipComma(ReaderBasedJsonParser.java:2429)
at com.fasterxml.jackson.core.json.ReaderBasedJsonParser.nextFieldName(ReaderBasedJsonParser.java:924)
at com.fasterxml.jackson.databind.deser.std.BaseNodeDeserializer._deserializeContainerNoRecursion(JsonNodeDeserializer.java:539)
at com.fasterxml.jackson.databind.deser.std.JsonNodeDeserializer.deserialize(JsonNodeDeserializer.java:104)
at com.fasterxml.jackson.databind.deser.std.JsonNodeDeserializer.deserialize(JsonNodeDeserializer.java:25)
at com.fasterxml.jackson.databind.deser.DefaultDeserializationContext.readRootValue(DefaultDeserializationContext.java:342)
at com.fasterxml.jackson.databind.ObjectMapper._readValue(ObjectMapper.java:4893)
at com.fasterxml.jackson.databind.ObjectMapper.readTree(ObjectMapper.java:3146)
at org.xwiki.contrib.changerequest.discussions.internal.ChangeRequestDiscussionDiffUtils$UnifiedDiffBlockDeserializer.deserialize(ChangeRequestDiscussionDiffUtils.java:78)
at org.xwiki.contrib.changerequest.discussions.internal.ChangeRequestDiscussionDiffUtils$UnifiedDiffBlockDeserializer.deserialize(ChangeRequestDiscussionDiffUtils.java:69)
at com.fasterxml.jackson.databind.deser.DefaultDeserializationContext.readRootValue(DefaultDeserializationContext.java:342)
at com.fasterxml.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:4917)
at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3860)
at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3828)
at org.xwiki.contrib.changerequest.discussions.internal.ChangeRequestDiscussionDiffUtils.deserialize(ChangeRequestDiscussionDiffUtils.java:200)
at org.xwiki.contrib.changerequest.discussions.internal.DefaultChangeRequestDiscussionService.getDiffBlockMetadata(DefaultChangeRequestDiscussionService.java:380)
{noformat}
Priority: Major Critical
 
 

1 comment

 
cid:jira-generated-image-avatar-24dea314-e91c-489c-bfba-09bdc3cce3fc Simon Urli on 02/Jun/25 10:45
 

The root cause is apparently that the metadata context of the discussion is broken after a refactoring: the reference is wrongly refactored in it.