There are 3 comments.
 
 
XWiki Platform / cid:jira-generated-image-avatar-483257e0-32d3-4153-b562-38d968a114de XWIKI-22496 Open

Link dialog option button is not keyboard operable

 
View issue   ยท   Add comment
 

3 comments

 
cid:jira-generated-image-avatar-6db27a4e-3c19-4994-8f6b-7469ff9e061f Charpentier Lucas on 04/Nov/24 17:29
 

Marius Dumitru Florea Yes, from what I could understand, CKEditor has its own system to handle focus order. With the time I've spent on this issue so far I could not figure out how to add this button (and also other custom objects that we have added) to their tab order. This means that keyboard accessibility on those elements is not respected even if we have the right HTML.

https://docs-old.ckeditor.com/ckeditor_api/symbols/CKEDITOR.focusManager.html

Fixing the HTML would usually be a sufficient fix, but here we should find a way to fit this in the CKEditor system too.

 
cid:jira-generated-image-avatar-6db27a4e-3c19-4994-8f6b-7469ff9e061f Charpentier Lucas on 04/Nov/24 17:30
 
[~mflorea] Yes, from what I could understand, CKEditor has its own system to handle focus order. With the time I've spent on this issue so far I could not figure out how to add this button (and also other custom objects that we have added to this modal ) to their tab order. This means that keyboard accessibility on those elements is not respected even if we have the right HTML.

https://docs-old.ckeditor.com/ckeditor_api/symbols/CKEDITOR.focusManager.html

Fixing the HTML would usually be a sufficient fix, but here we should find a way to fit this in the CKEditor system too.
 
cid:jira-generated-image-avatar-6db27a4e-3c19-4994-8f6b-7469ff9e061f Charpentier Lucas on 04/Nov/24 17:32
 
[~mflorea] Yes, from what I could understand, CKEditor has its own system to handle focus order. With the time I've spent on this issue so far I could not figure out how to add this button (and also other custom objects that we have added to this modal) to their tab order. This means that keyboard accessibility on those elements is not respected even if we have the right HTML.

https://docs-old.ckeditor.com/ckeditor_api/symbols/CKEDITOR.focusManager.html

Fixing the HTML would usually be a sufficient fix, but here we should find a way to fit this in the CKEditor system too.


Note that using automated tests (or most test tools in browsers) do not show these issues since the UI would work properly if not for the extra layer of javascript catching the Tab events to handle them with the focusManager from CKE.