There are 2 updates, 3 comments.
 
 
Book Versions / cid:jira-generated-image-avatar-c77d4b6a-2980-4ddd-9341-38cd41c4afc4 BVERSION-35 Reopened

The picker in the includeLibrary macro should propose only pages from the libraries configured in the book

 
View issue   ยท   Add comment
 

2 updates

 
cid:jira-generated-image-avatar-7224798c-eeb6-4f6c-87bd-63d098e24b9b Changes by Anca Luca on 23/Dec/24 00:29
 
Resolution: Fixed
Status: Closed Reopened
 
 

3 comments

 
cid:jira-generated-image-avatar-7224798c-eeb6-4f6c-87bd-63d098e24b9b Anca Luca on 23/Dec/24 00:29
 

After the implementation of the picker, the includeLibrary macro doesn't work anymore.

 
cid:jira-generated-image-avatar-7224798c-eeb6-4f6c-87bd-63d098e24b9b Anca Luca on 23/Dec/24 00:30
 
After Reopened to fix the fact that after the implementation of the picker, the includeLibrary macro doesn't work anymore.

Also, the suggestions for the libraries don't fully work - the suggest doesn't find the current value properly.
 
cid:jira-generated-image-avatar-7224798c-eeb6-4f6c-87bd-63d098e24b9b Anca Luca on 23/Dec/24 00:35
 

Reopened to fix the fact that after the implementation of the picker, the includeLibrary macro doesn't work anymore.

This seems to be related to the way the reference parameter is converted to a page reference, here: https://github.com/xwiki-contrib/book-versions/blob/master/application-book-versions-default/src/main/java/org/xwiki/contrib/bookversions/internal/displayers/LibraryReferenceConverter.java#L51 - the resolver used is a default resolver which resolves the value in the context of the main wiki. I think there are 2 possible solutions:

  • either we manage to convert it to the correct value
  • either we convert it to a relative reference, and leave it to the code of the macro to figure it out.

I think we should strive for the first solution.