This issue has been created
There are 7 updates, 1 comment.
 
 
XWiki Platform / cid:jira-generated-image-avatar-908172c8-5143-4f1c-adf4-88381bd94897 XWIKI-22320 Open

Validate URLs entered in the WYSIWYG link dialog

 
View issue   ยท   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-50b5f30e-2206-40e5-909d-045a5f0e02f7 Nikita Petrenko created this issue on 10/Jul/24 14:20
 
Summary: Introduce a validator for creating external links
Issue Type: cid:jira-generated-image-avatar-908172c8-5143-4f1c-adf4-88381bd94897 Improvement
Affects Versions: 16.5.0
Assignee: Unassigned
Created: 10/Jul/24 14:20
Priority: cid:jira-generated-image-static-minor-59996e12-974a-44b4-b76f-bd3339d532ba Minor
Reporter: Nikita Petrenko
Description:

Despite the fact that the placeholder displays an example of how a link to an external page should look, any user can mistakenly enter any character at the beginning in the value itself or at the end of it

As a result, after saving such a link, the user will not be able to open the external page since the URL is not valid

Therefore, either pre-saving or in real-time, XWiki should check whether the external link is valid (it URL syntax)

I am attaching the image that the user has when trying to open the link

`https://extensions.xwiki.org/xwiki/bin/view/Extension/WikiLinkURLNormalizer/
 
 

7 updates

 
cid:jira-generated-image-avatar-50b5f30e-2206-40e5-909d-045a5f0e02f7 Changes by Nikita Petrenko on 10/Jul/24 14:21
 
Description: Despite the fact that the placeholder displays an example of how a link to an external page should look, any user can mistakenly enter any character at the beginning in the value itself or at the end of it .

As a result, after saving such a link, the user will not be able to open the external page since the URL is not valid
.

Therefore, either pre-saving or in real-time, XWiki should check whether the external link is valid (it URL syntax)
.

I am attaching the image that the user has when trying to open the link

.
{code:none}
`https://extensions.xwiki.org/xwiki/bin/view/Extension/WikiLinkURLNormalizer/
{code}

Attachment: error in web-browser.png
Component: URLs
Labels: usability
 
cid:jira-generated-image-avatar-4d5487cd-f824-423f-8170-4b744a70fefb Changes by Vincent Massol on 10/Jul/24 14:22
 
Summary: Introduce a validator for creating external links Validate URLs entered in the WYSIWYG link dialog
Component: URLs
Component: CKEditor
 
 

1 comment

 
cid:jira-generated-image-avatar-4d5487cd-f824-423f-8170-4b744a70fefb Vincent Massol on 10/Jul/24 14:23
 

Notes:

  • If we implement it, we won't allow anymore to enter any reference when selecting a URL type
  • If we implement it, we also need to generate url:xxx types of link (instead of what the link dialog currently does)

Basically we're removing a potential hidden feature (but I think it's legit to remove it)