Branch: refs/heads/stable-16.10.x
Home:
https://github.com/xwiki/xwiki-platform
Commit: f0651b98ed094f800a5e36e7babab5c5354dacba
https://github.com/xwiki/xwiki-platform/commit/f0651b98ed094f800a5e36e7baba…
Author: Simon Urli <simon.urli(a)xwiki.com>
Date: 2025-04-01 (Tue, 01 Apr 2025)
Changed paths:
M
xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/commentsinline.vm
M
xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/CommentsIT.java
A
xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/CommentElement.java
M
xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/CommentsTab.java
M
xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/comments2.vm
Log Message:
-----------
XWIKI-22978: Comments are not ordered by date (#4015)
Provide a quickfix for ordering the comments directly in
commentsinline.vm. Since we cannot call directly $collectiontool.sort
because the Object property cannot be accessed by beanutils, we build a sorted
map indexed by date, taking into
account the rare possibility that 2 comments have been added at exact
same date.
Also all this work is duplicated in comments2.vm for fixing it in old
PDF export.
Note that ideally all this work should be refactored with a proper Java
API for comments, see also XWIKI-23049.
(cherry picked from commit 7afb957e90c71f106ccbb06f9eed657cb6c8ec4a)
To unsubscribe from these emails, change your notification settings at
https://github.com/xwiki/xwiki-platform/settings/notifications