[xwiki-notifications] [xwiki/xwiki-platform] 63700b: XWIKI-21988: Page naming strategy is blocking crea...

Branch: refs/heads/XWIKI-21988 Home: https://github.com/xwiki/xwiki-platform Commit: 63700b37284d560d290e873c3dbe2cca8a37e175 https://github.com/xwiki/xwiki-platform/commit/63700b37284d560d290e873c3dbe… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-07-08 (Mon, 08 Jul 2024) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/CreateAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/CreateActionRequestHandler.java M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/createinline.vm M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/js/xwiki/create.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/js/xwiki/xwiki.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/widgets/select/select.js Log Message: ----------- XWIKI-21988: Page naming strategy is blocking creation of pages not respecting it The goal here is to immediately display a feedback in the create page dialog telling the user that the reference is wrong before they click on create. I performed following changes here: * Refactor CreateActionRequestHandler to have a clean separation between retrieving the reference and performing checks over templates * Refactor a bit CreateAction to perform immediate checks over the rights and the name strategy before even checking if the template is chosen: the goal being here to immediately provide exception if there's a problem * Refactor createinline.vm to inject bootstrap modal html elements when used with an ajax request: the idea here is to display an ajax modal instead of the old deprecated xwiki dialog * Refactor xwiki.js to use a jquery ajax call to request and display createinline * Add listener on xwiki:dom:updated events in both create.js and select.js to properly load them in case of dom updates Some work is still needed to display a better information message to the user, in particular about the strategy that should be used. Commit: 83461a970e71e118773dc6ace816845fd451af6b https://github.com/xwiki/xwiki-platform/commit/83461a970e71e118773dc6ace816… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-07-08 (Mon, 08 Jul 2024) Changed paths: M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-api/src/main/resources/ApplicationResources.properties A xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-default/src/main/resources/ApplicationResources.properties M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-ui/src/main/resources/XWiki/EntityNameValidation/Translations.xml M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/createinline.vm Log Message: ----------- XWIKI-21988: Page naming strategy is blocking creation of pages not respecting it * Provide new translations for getting better information from the name strategy * Improve a bit the template for displaying errors Commit: 668433e78409f8b26677a75919b3ddf189be7d93 https://github.com/xwiki/xwiki-platform/commit/668433e78409f8b26677a75919b3… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-07-08 (Mon, 08 Jul 2024) Changed paths: M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/test/java/org/xwiki/web/CreateInlinePageTest.java Log Message: ----------- XWIKI-21988: Page naming strategy is blocking creation of pages not respecting it * Fix page test Commit: af403bffb93bf40c128742ccf77187a9d2664607 https://github.com/xwiki/xwiki-platform/commit/af403bffb93bf40c128742ccf771… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-07-08 (Mon, 08 Jul 2024) Changed paths: M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/ViewPage.java Log Message: ----------- XWIKI-21988: Page naming strategy is blocking creation of pages not respecting it * Fix page object Compare: https://github.com/xwiki/xwiki-platform/compare/eb7032d8a231...af403bffb93b To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications