| The manual test is here: Disable Search Suggest The test verifies if disabling search suggest feature works properly. Apart from the steps from the manual test, it would be great if a functional test to change the search suggest sources can be added. Matrix discussion: https://matrix.to/#/!ikPtGZaGWtyblizzlR:matrix.xwiki.com/$17194938241240WDFPD:matrix.xwiki.com?via=matrix.org&via=matrix.xwiki.com&via=helsinki-systems.de Ilie Andriuta: Hi! Continuing the manual tests migration, there is a test about checking if disabling search suggest feature works properly: https://test.xwiki.org/xwiki/bin/view/Administration%20Tests/Disable%20Search%20Suggest. I've checked https://github.com/xwiki/xwiki-platform/blob/10320a1054a3fceec35f0b1c3b5e0cb519742269/xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-test/xwiki-platform-search-test-docker/src/test/it/org/xwiki/search/test/ui/SearchSuggestIT.java#L34 but it seems I didn't find automated tests. Can you please confirm? Thanks! Vincent Massol: checking
BTW Ilie Andriuta
when you have time, it would be interesting to reply to https://forum.xwiki.org/t/status-of-manual-tests-vs-automated-tests-strategy/14948  (no urgency)
Ilie Andriuta: Hi! yes, I just formulated the answer, sorry for delay, I am currently focused on testing 16.4.0
replied
Vincent Massol: np, thx
Vincent Massol: Pierre: seems you've used the word "faucet" in several places in https://github.com/xwiki/xwiki-platform/commit/acba74c149a041345b24dcca52c586f872ba97fb#diff-dd635728ddcb197cab83e88599889756b3c8517cf3b2defa59b1aeef4a34617aR52 A faucet is a "robinet" in French I think you meant "facet" Vincent Massol: I can't find it indeed, nor any functional test to change the search suggest sources
Ilie Andriuta: ok, I will create a task for it
thanks, Vincent!
Vincent Massol: yw |
