I did not propose the look and feel since it seems pretty straightforward to me (and I didn't really push for the PR to be merged yet, there's no comment about it, if you don't agree with it we can discuss and eventually open a proposal). The idea of having panel column toggler has been discussed and asked for in multiple places so I figured I'd try to propose something. Note that it used to be in old versions of XWiki but AFAIR it got removed when we moved to the Flamingo skin. It could even be considered a regression fix
I don't have a problem with the feature proposed nor any big concern about the toggler (although it looks a bit odd but I don't have a better idea). My only point is that any visual change is better discussed with everyone, as L&F is very subjective and it's hard to get a consensus and there's no absolute truth. Since the issue has been opened for a long time already, we would have had plenty of time to agree on a L&F (in other words, PRs are not the best place to make UI proposals as not all the xwiki users nor xwiki devs will look there).
Vincent Massol on 10/Jul/24 16:38
bq. I did not propose the look and feel since it seems pretty straightforward to me (and I didn't really push for the PR to be merged yet, there's no comment about it, if you don't agree with it we can discuss and eventually open a proposal). The idea of having panel column toggler has been discussed and asked for in multiple places so I figured I'd try to propose something. Note that it used to be in old versions of XWiki but AFAIR it got removed when we moved to the Flamingo skin. It could even be considered a regression fix
I don't have a problem with the feature proposed nor any big concern about the toggler (although it looks a bit odd but I don't have a better idea). My only point is that any visual change is better discussed with everyone, as L&F is very subjective and it's hard to get a consensus and there's no absolute truth. Since the issue has been opened for a long time already, we would have had plenty of time to agree on a L&F (in other words, PRs are not the best place to make UI proposals as not all the xwiki users nor xwiki devs will look there). That being said, it's also fine to go ahead and iteratively change it in the future if someone doesn't like it (just a bit more work overall and longer time to stabilize).
