This issue has been created
 
 
XWiki Platform / cid:jira-generated-image-avatar-0ba0aa10-89a7-4b77-b208-468e9f5ef753 XWIKI-22209 Open

Deprecate NotificationFilterPreference#isActive

 
View issue   ยท   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-74812dfa-805e-4577-b767-6af59eac1d63 Simon Urli created this issue on 03/Jun/24 15:20
 
Summary: Deprecate NotificationFilterPreference#isActive
Issue Type: cid:jira-generated-image-avatar-0ba0aa10-89a7-4b77-b208-468e9f5ef753 Improvement
Affects Versions: 15.10.10
Assignee: Unassigned
Components: Notifications
Created: 03/Jun/24 15:20
Priority: cid:jira-generated-image-static-major-f219df5b-6bb5-4f47-b346-4210a14d6ffd Major
Reporter: Simon Urli
Description:

The concept of active notification filter preferences does not make sense anymore, the javadoc says:

A filter preference can either be active or passive. It the preference is active, then it should force the retrieval of notifications when used in conjunction with a {@link NotificationFilter}.

On the other hand, a passive (non-active) notification filter should not automatically trigger the retrieval of notifications.

This was probably valid back then when notifications were using a post-filtering mechanism to be retrieved, but now that we're using prefiltering by default it doesn't make sense anymore.