There are 5 updates, 1 comment.
 
 
XWiki Platform / cid:jira-generated-image-avatar-2db5cd12-9871-4552-a5c9-cc38f292c6fd XWIKI-22036 Closed

Call "hasNext" before call "next" in XWikiDocumentArchive

 
View issue   ยท   Add comment
 

5 updates

 
cid:jira-generated-image-avatar-55835acf-1eb1-43f7-9464-d837c685c3a8 Changes by Vincent Massol on 14/Nov/24 13:51
 
Documentation in Release Notes: N/A
Documentation: N/A
Resolution: Cannot Reproduce
Labels: bugfixingday
Status: Open Closed
 
 

1 comment

 
cid:jira-generated-image-avatar-55835acf-1eb1-43f7-9464-d837c685c3a8 Vincent Massol on 14/Nov/24 13:51
 

I've closed the PR at https://github.com/xwiki/xwiki-platform/pull/3036#issuecomment-2476278409

The reason mentioned there is:

@Xiqinger thanks a lot for you PR. However, I don't think the main change is needed (I don't see how you could have reproduced the problem so I suspect you just tried to fix it based on the code without writing a test for it, is that so or were you able to reproduce the issue?). And the second change is not related to the JIRA issue mentioned for the PR (I'm also not sure if the problem re the table name is real or not).

FTM I'l close the issue but if you can bring arguments for it, we can reopen it. Thanks a lot!