| The manual test is here: https://test.xwiki.org/xwiki/bin/view/Administration%20Tests/Uninstall%20Extension The test verifies the history behavior when an extension is uninstalled. Matrix discussion: https://matrix.to/#/!ikPtGZaGWtyblizzlR:matrix.xwiki.com/$17297733291098zVXQh:matrix.xwiki.com?via=matrix.org&via=matrix.xwiki.com&via=mtrx.nz Thomas@tmortagne:matrix.xwiki.com: Ilie Andriuta
Hi! Continuing the manual tests migration, there is a test about checking if the behaviour is correct when uninstalling an extension from Extension Manager: https://test.xwiki.org/xwiki/bin/view/Administration%20Tests/Uninstall%20Extension
I've checked https://github.com/xwiki/xwiki-platform/blob/73b07f8352d1716b9945b577d6e4a3334f058a77/xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-script/src/test/java/org/xwiki/extension/script/ExtensionManagerScriptServiceTest.java and https://github.com/xwiki/xwiki-platform/blob/060a43e359ff19d49db049798be0fdf0dc876947/xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/java/org/xwiki/test/docker/internal/junit5/ExtensionInstaller.java but it seems I couldn't find automated tests for it.
Can you please confirm whether the automated test exists for it or not and maybe providing the link to it? Thanks! https://github.com/xwiki/xwiki-platform/blob/060a43e359ff19d49db049798be0fdf0dc876947/xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/java/org/xwiki/test/docker/internal/junit5/ExtensionInstaller.java is not a test, it's a test tool.
https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-test/xwiki-platform-extension-test-tests/src/test/java/org/xwiki/test/ui/extension/ExtensionIT.java does seems to test uninstall extensions
(and there are also a lot of unit tests related to extension uninstall)
So IMO https://test.xwiki.org/xwiki/bin/view/Administration%20Tests/Uninstall%20Extension is covered. Ilie Andriuta: Thanks, Thomas!
hm, the test is about the behavior, i.e. Progress bar appears, Message confirming successful uninstallation appears, The uninstalled extension can be seen in Extension History (Extensions > History)
is this covered also?
for ex for https://test.xwiki.org/xwiki/bin/view/Administration%20Tests/Install%20Extension I created https://jira.xwiki.org/browse/XWIKI-19941 for it wasn't automated Ilie Andriuta: I think it's about the Progress bar just being displayed and filling as the process is ongoing
Thomas@tmortagne:matrix.xwiki.com: But I don't see any reference to the extension history.
Marius Dumitru Florea: any idea if the extension history is tested somewhere else (or here and I missed it) ?
Marius Dumitru Florea: I can't find any related page object, https://github.com/search?q=repo%3Axwiki%2Fxwiki-platform+extensionhistory+language%3AJava&type=code&l=Java , so I don't think the extension history has automated tests. |
