There is 1 update, 1 comment.
 
 
OpenId Connect / cid:jira-generated-image-avatar-d7b23104-b016-4b84-9707-d9fccfebddc8 OIDC-203 Open

OIDC Authenticator will try to synchronize groups even if no mapping is defined

 
View issue   ·   Add comment
 

1 update

 
cid:jira-generated-image-avatar-ee48a437-95ed-4489-9de3-6889533e2008 Changes by Clément Aubin on 19/Nov/24 09:52
 
Priority: Major Critical
 
 

1 comment

 
cid:jira-generated-image-avatar-ee48a437-95ed-4489-9de3-6889533e2008 Clément Aubin on 19/Nov/24 09:51
 

Thomas Mortagne I understand the intent behind OIDC-185, but the issue we face is that the change it brought has unintended side-effects, because the group synchronization will run even if the group mapping is null (see https://github.com/xwiki-contrib/oidc/blob/8e624ade09a6a10b9e695d16d90762c311504b2a/oidc-authenticator/src/main/java/org/xwiki/contrib/oidc/auth/internal/OIDCUserManager.java#L690)

We can get situation where users can be removed from groups there were in before, simply because an admin upgraded the OIDC authenticator.