[xwiki-notifications] [xwiki/xwiki-platform] f2aba3: XWIKI-21988: Page naming strategy is blocking crea...

Branch: refs/heads/backport-3229-to-stable-16.4.x Home: https://github.com/xwiki/xwiki-platform Commit: f2aba3e05c7c49101bcff26bb9044f0fccad5393 https://github.com/xwiki/xwiki-platform/commit/f2aba3e05c7c49101bcff26bb904… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-07-09 (Tue, 09 Jul 2024) Changed paths: M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-api/src/main/resources/ApplicationResources.properties A xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-default/src/main/resources/ApplicationResources.properties A xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-default/src/main/resources/ApplicationResources_de.properties A xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-default/src/main/resources/ApplicationResources_es.properties A xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-default/src/main/resources/ApplicationResources_fr.properties A xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-default/src/main/resources/ApplicationResources_ja.properties A xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-default/src/main/resources/ApplicationResources_ko.properties A xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-default/src/main/resources/ApplicationResources_ru.properties A xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-default/src/main/resources/ApplicationResources_uk.properties M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-ui/src/main/resources/XWiki/EntityNameValidation/Translations.de.xml M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-ui/src/main/resources/XWiki/EntityNameValidation/Translations.es.xml M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-ui/src/main/resources/XWiki/EntityNameValidation/Translations.fr.xml M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-ui/src/main/resources/XWiki/EntityNameValidation/Translations.ja.xml M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-ui/src/main/resources/XWiki/EntityNameValidation/Translations.ko.xml M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-ui/src/main/resources/XWiki/EntityNameValidation/Translations.ru.xml M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-ui/src/main/resources/XWiki/EntityNameValidation/Translations.uk.xml M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-ui/src/main/resources/XWiki/EntityNameValidation/Translations.xml M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/CreateAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/CreateActionRequestHandler.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/ViewPage.java M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/createinline.vm M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/test/java/org/xwiki/web/CreateInlinePageTest.java M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/js/xwiki/create.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/js/xwiki/xwiki.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/widgets/select/select.js Log Message: ----------- XWIKI-21988: Page naming strategy is blocking creation of pages not respecting it (#3229) The goal here is to immediately display a feedback in the create page dialog telling the user that the reference is wrong before they click on create. I performed following changes here: * Refactor CreateActionRequestHandler to have a clean separation between retrieving the reference and performing checks over templates * Refactor a bit CreateAction to perform immediate checks over the rights and the name strategy before even checking if the template is chosen: the goal being here to immediately provide exception if there's a problem * Refactor createinline.vm to inject bootstrap modal html elements when used with an ajax request: the idea here is to display an ajax modal instead of the old deprecated xwiki dialog * Refactor xwiki.js to use a jquery ajax call to request and display createinline * Add listener on xwiki:dom:updated events in both create.js and select.js to properly load them in case of dom updates * Provide new translations for getting better information from the name strategy * Improve a bit the template for displaying errors * Fix page test * Fix page object * Move translations * Fix typos in translations * Fix since (cherry picked from commit 0d91409d433c2df6a5c13cec761d913342235b2c) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications