This issue has been created
 
 
XWiki Platform / cid:jira-generated-image-avatar-7b52c398-79bf-42e1-8c9f-3c807b4c7cd6 XWIKI-23083 Open

Search result 'Highlight all matches' should be a button instead of a link without a reference

 
View issue   ยท   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-b49c2b48-0ccb-405f-bc7e-8f59fc6d5a22 Charpentier Lucas created this issue on 08/Apr/25 15:25
 
Summary: Search result 'Highlight all matches' should be a button instead of a link without a reference
Issue Type: cid:jira-generated-image-avatar-7b52c398-79bf-42e1-8c9f-3c807b4c7cd6 Bug
Affects Versions: 17.3.0-rc-1
Assignee: Unassigned
Attachments: Screenshot from 2025-04-08 15-21-09.png
Components: Search - UI
Created: 08/Apr/25 15:25
Labels: wcag
Priority: cid:jira-generated-image-static-major-3a20413d-311c-46a6-bcad-040b8ce3f652 Major
Reporter: Charpentier Lucas
Description:

The element to `highlight all matches` has an action on the page, it expands information to show all the matches.
This is typically an action that is done by a button. Links should be reserved for movement action: changing page or changing place in the page. If the action has an effect on the page, it should be a button.

This button should also probably have `aria-expanded = false` and `aria-control` set from the get go, so that AT users can leverage the semantics and use it with ease.