There are 2 comments.
 
 
Book Versions / cid:jira-generated-image-avatar-d6bb4ada-a77b-4588-ad0f-d77c8bedb0fd BVERSION-18 Open

Add listener to handle inheritance collisions on version delete

 
View issue   ยท   Add comment
 

2 comments

 
cid:jira-generated-image-avatar-268fe833-2ef8-49ae-bdaf-d1ef41095967 Anca Luca on 09/Dec/24 00:16
 

Paul Pantiru actually, I just realized that you used the term "collision" here, can you explain more clearly what do you mean by it?

More specifically: from the pov of the model of books and versions, I don't see what kind of "collision" would happen if a version that is marked as being the "parent version" of another version is deleted. The inheritance "chain" would be broken, any version that declares the deleted version as its parent would behave as a "root" version, a parentless version. What's colliding with what?

Now, it may be that the behavior, in the current implementation, is not correctly implemented (the orphaned version doesn't behave as a toplevel), and those "too many redirects" happen, but 1/ that's not really a collision and 2/ it's a bug that orphans are not correctly handled (as I explained above, I don't see any reason why we shouldn't be able to handle orphans properly).

 
cid:jira-generated-image-avatar-268fe833-2ef8-49ae-bdaf-d1ef41095967 Anca Luca on 09/Dec/24 00:17
 
[~ppantiru] actually, I just realized that you used the term "collision" here, can you explain more clearly what do you mean by it?

More specifically: from the pov of the model of books and versions, I don't see what kind of "collision" would happen if a version that is marked as being the "parent version" of another version is deleted. The inheritance "chain" would be broken, any version that declares the deleted version as its parent
- and is now "orphaned" - would behave as a "root" version, a parentless version. What's colliding with what?

Now, it may be that the _behavior_, in the current implementation, is not correctly implemented (the orphaned version doesn't behave as a toplevel), and those "too many redirects" happen, but 1/ that's not really a collision and 2/ it's a bug that orphans are not correctly handled (as I explained above, I don't see any reason why we shouldn't be able to handle orphans properly).