Make LESS customizations impact CSS properties

View issue · Add comment

Issue created

Charpentier Lucas created this issue on 08/Apr/25 11:05

Summary:	Make LESS customizations impact CSS properties
Issue Type:	Improvement
Affects Versions:	17.3.0-rc-1
Assignee:	Unassigned
Components:	Flamingo Skin
Created:	08/Apr/25 11:05
Priority:	Major
Reporter:	Charpentier Lucas
Description:	As of ~~XWIKI-22667~~, we do have a set of CSS properies. However, any customization of the LESS equivalents does not work on their equivalent CSS properties. It is expected that CSS properties that have an equivalent in LESS always have the same value of this equivalent by default. It would make the migrations way safer. Customizations that are not currently reflected in CSS variables are contained in the FlamingoColorTheme Advanced `@lessCode` and SSXs for example. I think it's fair to only use the customizations at the :root level. For any customization of the value of a variable which is not at the root level, the migration will need to be handled by hand.

1 update

Changes by Charpentier Lucas on 08/Apr/25 11:13

Assignee:

Charpentier Lucas

4 comments

	Charpentier Lucas on 08/Apr/25 11:07

	This task can be done in parallel to XWIKI-23029. Bootswatch themes use a lot of variables that are found only in Bootstrap and not XWiki. It makes sense to create new CSS properties for these variables only when a bootswatch theme is used.

	Charpentier Lucas on 08/Apr/25 11:08

	This will make the migration of XS files to native CSS way safer and faster.

	Charpentier Lucas on 08/Apr/25 11:08

	This will make the migration of XS files to native CSS ( XWIKI-22668 ) way safer and faster.

Charpentier Lucas on 08/Apr/25 11:13

In my opinion, we should keep a list of exceptions for this rule. With the new CSS system, we sometimes want to do things better, another way. If we tie this new system to LESS without exceptions, we cannot improve things without breaking backwards compatibility of LESS styles.

E.g. the font-size variables should not get their values from LESS, we want the default font-sizes to be set in rem/em and not px anymore (XWIKI-21873) .

This message was sent by Atlassian Jira (v9.3.0#930000-sha1:287aeb6)

If image attachments aren't displayed, see this article.