| The manual test is here: Show User and Group Rights The test verifies if the list of Users and Groups is properly displayed on Rights UI from Administration. What is needed is to add tests to validate the rights UI for users. Matrix discussion: https://matrix.to/#/!ikPtGZaGWtyblizzlR:matrix.xwiki.com/$1718881946713TSMyK:matrix.xwiki.com?via=matrix.org&via=matrix.xwiki.com&via=helsinki-systems.de Ilie Andriuta: Hi! Continuing the manual tests migration, there is a test about checking if the list of Users and Groups is properly displayed on Rights UI from Administration: https://test.xwiki.org/xwiki/bin/view/Administration%20Tests/Show%20User%20Rights. I've checked https://github.com/xwiki/xwiki-platform/blob/858605a25625999f2e1e263b35e43ffd77b92ee0/xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-test/xwiki-platform-administration-test-docker/src/test/it/org/xwiki/administration/test/ui/UsersGroupsRightsManagementIT.java#L336 and it seems some automated tests exist but I don't know if the expected result from the manual one is included. Can you please confirm? Thanks!
Vincent Massol: checking
note that the test is not very precise and doesn't mention what 'properly' means
Ilie Andriuta: it means the checkboxes are in their place, aligned correctly
and the list includes all users/groups
Vincent Massol:
then you should list that in the expected outcome I guess 
Ilie Andriuta: maybe I should update the expected results with the info
yes
Vincent Massol: re alignment we don't have any tests that verifies ui alignments
nor image placement nor anything visual
but I don't think it's that important for this test as otherwise we woudn't be able to automate any ui test
IMO re alignment, positions, and all things visuals you need to have a dedicated test to navigate the wiki to find issues about this, independent of the specific tests
Ilie Andriuta:
when running this manual test, for me i's important to check the check boxes alignment and if there is no issue with the UI
Vincent Massol: as I said, in that case you can reopen all the tests we marked as automated 
since they are all abut UIs and thus it's always possible to check for alignments and the like
Ilie Andriuta: ok, then we can check only if the lists are displayed ok
for the purpose of this test
Vincent Massol: checking what we have
Ilie Andriuta: anyway on manual testing we check also the UI and if there are related issues, it's part of it 🙂
Vincent Massol: yes but not supposed to do manual testing of tests marked as automated, so you'll need to test this as part of some other test, something like a smoke test for visual issues
Ilie Andriuta: sure
Vincent Massol: So the automated test you mentioned is testing:
Ilie Andriuta: ok, in this case should I create a ticket for the users tests to be added?
and if they already exist, the ticket can be closed, but to be sure
Vincent Massol: I also searched for urogu in the code which is the "users" radio button and didn't find any usage of it in tests except for the one mentioned above
Ilie Andriuta: I see
Vincent Massol: BTW the test mentioned above in AllDocsIT is not correct IMO as I don't see why it needs to navigate in the UI to perform the assert
the navigation to check rights should be done in a test that tests the rights ui yes I think we need an issue to add tests to validate the rights UI for users
if it doesn't exist |
