On 7/8/07, Vincent Massol <vincent@massol.net> wrote:

Hi Tharindu/Asiri,

Great job! I think it's time to try integrating your code in our source tree and start doing some code review of it to verify it's using XWiki's coding best practices.

I propose the following:
- Tomorrow I create a xwiki-extensions module for xwiki extensions and I drop your latest sources (1.0.1) in SVN
- I start a vote to give both Asiri and you write access to it
- I create a separate jira project for it

WDYT?

I've started using your plugin and I can already see several killer features in the future:

* Defaults to using the Veloedit editor (http:://veloedit.sourceforge.net). When right clicking a document in the navigation, there should be an "open with" menu with "Simple Editor" (the current editor you have) or "Velocity Editor" (or "Groovy Editor" for the future - There's a groovy plugin for eclipse).

Sounds really cool. I think we can simply provide a pull down menu (in the editor) and let the user select what type of editing he prefers. In eclipse there is flexibility of dynamically plugging different SourceViewConfigurers. For an example, when the user selects velocity as editing mode, only velocity syntax would be highlighted and context sensitive help also changes accordingly. This would require us to extract corresponding code from Veloedit, but i believe this wouldn't be that difficult.

* Allow navigation directly to a page when hitting a shortcut or right-clicking in a internal link in the editor window. This can be easily implemented with the DocumentParser and LinkParser classes (about 5-10 lines of code)

I thought of this too. Though I was wondering how... :)

- Asiri

* Offer a XAR export view in addition to the "print" view in the simple editor. Note: before we can do this we need to create a URL for this in xwiki platform. This would make it easy to develop new pages and save them in XWiki's source tree

Thanks
-Vincent

On Jul 7, 2007, at 11:48 AM, tharindu jayasuriya wrote:

We have completed work allocated for Milestone-2 of XWiki-Eclipse-Plugin (+ more).

http://jira.xwiki.org/jira/browse/XWIKI-1361

Implemented Features:

- view existing pages (as xwiki markup or browser output)
- edit xwiki markup (using TextEditor widget in eclipse)
- save edited content

Although we encountered some problems as well,

- We couldn't prepare the pom.xml file such that maven produces a deployable plugin component. Eclipse needs the plugin jar file to have a specific format and maven enforces a different format, we're still struggling to get it right (need some help). Although compilation and other stuff or quite ok.

- Eventhough the edited XWiki Markup can be saved, the output(in browser) does not reflect changes untill we restart XWiki. Is there a way to forcefully flush the cache ? can this be done remotely ?

All comments are welcome!

Thanks a lot!!!

- Tharindu & Asiri

--
You receive this message as a subscriber of the xwiki-dev@objectweb.org mailing list.
To unsubscribe: mailto:xwiki-dev-unsubscribe@objectweb.org
For general help: mailto:sympa@objectweb.org?subject=help
ObjectWeb mailing lists service home page: http://www.objectweb.org/wws

--
You receive this message as a subscriber of the xwiki-dev@objectweb.org mailing list.
To unsubscribe: mailto:xwiki-dev-unsubscribe@objectweb.org
For general help: mailto: sympa@objectweb.org?subject=help
ObjectWeb mailing lists service home page: http://www.objectweb.org/wws