Re: [xwiki-devs] [xwiki-notifications] r24164 - platform/core/trunk/xwiki-officeimporter/src/main/java/org/xwiki/officeimporter/internal/openoffice

1 Oct 2009


      Hi,
...
...
+    private boolean isMainXWiki()
+    {
+        String currentWiki =
docBridge.getCurrentDocumentName().getWiki();
+        return (currentWiki != null) && currentWiki.equals("xwiki");
This is bad....
We shouldn't hardcode the main wiki name. What if we change it later
on? We'll need to check every places. It needs to be centralized and
there's already a method for this in the XWiki class AFAIK.
I can't find such a method which can be accessed from components. I agree
that we need this, I asked this question today in jabber chat, nobody
answered :(

- Asiri

Re: [xwiki-devs] [xwiki-notifications] r24164 - platform/core/trunk/xwiki-officeimporter/src/main/java/org/xwiki/officeimporter/internal/openoffice

Asiri Rathnayake