Re: [xwiki-devs] Map Application - GSoC 19

I've used the latest build from https://github.com/9inpachi/interactive-maps-new and I have the error both on 11.4-rc-1 and some 11.4-snapshot. Thanks, Caty On Wed, Jun 5, 2019 at 8:30 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com&gt; wrote: > Hi, > > Caty, do you have the error with the latest git repo as well? > Actually the leaflet-commons require leaflet but the functions are not > actually called anywhere without the leaflet dependency used in require. > > There is no error on my or Stephane side. > I have the 11.3-rc version of XWiki. > You can try Ctrl+F5 for a complete new load of the resources. > > Best, > Fawad > > On Wed, Jun 5, 2019, 10:22 PM Ecaterina Moraru (Valica) < > valicac(a)gmail.com wrote: > >> Hi, >> >> Some notes: >> - We don't have guidelines regarding the singular / plural thing. I'm >> glad that on the new sources we don't have the Maps/Map anymore. I'm fine >> with Maps. In practice we have a mix of singular (like Diagram, Calendar, >> Meeting) and plural (like Ideas, Forums). I prefer the plural version, >> although in practice I think we have more with singular. There was a >> tentative old draft for having such guidelines >> https://design.xwiki.org/xwiki/bin/view/Proposal/ApplicationGuidelines >> but we didn't worked on it for some time. >> >> - Regarding the new Git repository. Since you've committed the initial >> commits in issues, you should do a release with the initial version, and >> than just release a new version for the interactive-maps-new . It's normal >> in an application's development flow that changes happen, that's why >> versioning schemes are all about. >> >> - I still have the error I've mentioned before : >> Uncaught Error: Script error for "leaflet", needed by: leafletSearch >> http://requirejs.org/docs/errors.html#scripterror >> at F (require.min.js?r=1:7) >> at HTMLScriptElement.onScriptError (require.min.js?r=1:30) >> >> leaflet.css:1 Failed to load resource: the server responded with a >> status of 404 (Not Found) >> >> so I cannot actually test the build, since I don't see the maps. I have >> this both on Chrome and Firefox. Do I need to do something? >> >> Thanks, >> Caty >> >> On Tue, Jun 4, 2019 at 2:31 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com&gt; >> wrote: >> >>> Also, I forgot to mention it before but we will need a better and more >>> expressive way to show popups. We need something that can accomodate >>> sufficient amount of text with a scroll if the information exceeds the page. >>> I will prepare a mockup for this once I am done with some of the next >>> steps. >>> >>> And I think we should use the colortheme colors for our map controls >>> and consequently for the popups. I will update you on that as well. >>> >>> Best, >>> Fawad >>> >>> >>> On Tue, Jun 4, 2019 at 3:31 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com&gt; >>> wrote: >>> >>>> Hi Stephane, Caty and all, >>>> Hope you are doing fine. >>>> >>>> I am glad you brought up the topic of custom marker icon. I am well >>>> aware of the issue. Actually there are two problems with custom markers. >>>> - The icon offset >>>> - The document attachment >>>> >>>> For the icon offset, when I tried to fix it initially it seemed that I >>>> can overcome the offset either by height or width which means that the >>>> offset still exists from a single side so I had that postponed since I >>>> thought solr query tasks take priority. >>>> >>>> For the attachment, for now I am getting the first attachment (0th >>>> index) from the Point page which is not very reliable. For example if we >>>> have images on the page, it could be that the marker takes one of the >>>> attachments even if the user did not want a custom icon or an image >>>> different from what the user wanted to choose is selected as the marker >>>> icon. >>>> >>>> What I have in mind is that we define categories for marker icons >>>> dynamically. >>>> We could make a separate dedicated page "MarkerIcons" and attach >>>> multiple images to it. Then these images could appear in a list as one of >>>> the properties in the Point object where we can choose the icon from. WDYT? >>>> >>>> Thanks, >>>> Fawad >>>> >>>> On Tue, Jun 4, 2019, 11:31 AM Stéphane Laurière &lt;slauriere(a)xwiki.com >>>> wrote: >>>> >>>>> Fawad, Thanks for letting us know, I could install the new app >>>>> version, I confirm that all the changes you added to the progress file >>>>> (very handy) work for me, and the refactoring is ok. I noticed a minor >>>>> issue that you're certainly aware of already: it seems there's a small >>>>> offset between the custom marker position (with the Islamabad point) and >>>>> the popup position. >>>>> >>>>> Talk to you soon, >>>>> >>>>> Stéphane >>>>> >>>>> >>>>> Fawad Ali: >>>>> > Hi all, >>>>> > >>>>> > Thanks for the detailed review, Stephane. I have made the changes >>>>> you suggested with some next steps also done. >>>>> > >>>>> > Furthermore, I will make changes to the application space once we >>>>> have confirmed response from Caty or other developers. >>>>> > I have started to work on the other next steps and will provide >>>>> with updates soon. >>>>> > >>>>> > The original github repo is also updated, so future updates will be >>>>> available at >>>>> https://github.com/xwiki-contrib/application-interactive-maps. >>>>> > >>>>> > Thanks, >>>>> > Fawad >>>>> >>>>> >>>>> -- >>>>> Stéphane Laurière >>>>> XWiki – https://xwiki.com >>>>> >>>>> >>>>>