Hi Vincent,<br><br><div><span class="gmail_quote">On 8/6/07, <b class="gmail_sendername">Vincent Massol</b> &lt;<a href="mailto:vincent@massol.net">vincent@massol.net</a>&gt; wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div style="">Hi Tharindu,<div><br></div><div>(I&#39;ve copied the dev list, please send all dev related information to the list please so that we&#39;re all on the same page)</div><div><br></div><div>See below.</div><div>
<br><div><div>On Aug 6, 2007, at 8:34 AM, tharindu jayasuriya wrote:</div><br><blockquote type="cite">Hi Vincent,<br><br>Sorry about the late reply.<br><br>I have mistaken the XWiki account information with object web details.
<br><br>Tharindu - tharinduj<br><br>Asiri - asiri (newly created)<br></blockquote><div><br></div>Done. You can now do commits on xwiki-sandbox/xeclipse.</div><div><br><blockquote type="cite">---------------------------------------------------------------------------------- 
<br><br>Also, we need some help regarding XEclipse off-line. We are struggling bit to find a place to start development. And one more question, do we need to complete the off-line operation mode within GSoC time period ? we&#39;re having trouble with academic work load. 
<br></blockquote><div><br></div><div>I think you need to provide a simple offline feature which is the ability to:</div><div>- save pages locally (I recall there&#39;s an easy eclipse api for this)</div><div>- ability to choose what to download from the server: a page, a full space or a full wiki
</div><div>- ability to check if the page isn&#39;t more recent on the server on save and if so warn the user and let him decide what to do: overwrite the server version or cancel</div><div>- ability to refresh one&#39;s own copy of saved pages&nbsp; with the server&#39;s versions
</div></div></div></div></blockquote><div><br>I&#39;ve been thinking about XEclipse off-line for a while and I can&#39;t see an easy way out. May be I&#39;m not on the right&nbsp; track, but i believe there is a plenty of work that need to be done in order to implement off-line operation of XEclipse.
<br><br>This is the scheme I propose,<br><br>1. When the user creates a connection for the first time, we create a local cached file hierarchy that resembles the corresponding wiki site.  <br><br>2. When user make changes to pages, we update the local cache as well as the server.
<br><br>This way, we can let the user operate in a &quot;disconnected&quot; mode without committing changes to the server copy, and once he wishes to do so, he can flush the local cache to the server (with some validity checks).
<br><br>As it is obvious by now, the current implementation need to be changed a bit to accommodate for these requirements.<br><br>I don&#39;t know whether this is the only solution, but this is the way i saw it. Please let me know if you believe there is an easy way.
<br><br>We&#39;re looking forward to start on XEclipse off-line asap, but need to finalize the approach upfront. <br><br>Btw, are there any work left for M1 ?<br><br>Thanks.<br><br>- Asiri<br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div style=""><div><div><div>Basically this means everything except the hard part which is the synchronization.</div><div><br></div><div>Let me know if this is possible but I don&#39;t think this is too hard to do and it&#39;s important for such a tool I think.
</div><div><br></div><div>Now I haven&#39;t reviewed what&#39;s left you have to do for 1.1M2 but that needs to be finished as a priority.</div><div><br></div><div>Let me know if you have any schedule issues with this and we&#39;ll try to find a solution. I&#39;ll work on the m2 build this coming week to help you.
</div><div><br></div><div>Thanks</div><div>-Vincent</div><div><br></div><blockquote type="cite"><div><span class="q"><span class="gmail_quote">On 8/4/07, <b class="gmail_sendername">Vincent Massol</b> &lt;<a href="mailto:vincent@massol.net" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
vincent@massol.net</a>&gt; wrote:</span></span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div>Hi Tharindu,<div><br></div><div>I&#39;ve tried adding both of you but your ids don&#39;t exist on 
forge.objectweb.org...<div><br></div><div>I&#39;ve committed&nbsp; xeclipse into xwiki-sandbox but you don&#39;t have write access yet as I couldn&#39;t add you... </div><div><br></div><div>Thanks</div><span><div>-Vincent</div>
</span><div><span><div><br><div><div>On Aug 3, 2007, at 5:56 PM, tharindu jayasuriya wrote:</div><br><blockquote type="cite"> Hi Vincent,<br><br><div><span class="q"><span class="gmail_quote">On 8/3/07, <b class="gmail_sendername">
Vincent Massol</b> &lt;<a href="mailto:vincent@massol.net" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">vincent@massol.net </a>&gt; wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
 <div>Hi Tharindu/Asiri,<div><br></div><div>I have reviewed the patch and it looks good. Only potential issue is the package name you&#39;ve used: org.xwiki.plugins. So far we&#39;ve used com.xpn.xwiki.*. However you&#39;re correct that we want to move to 
org.xwiki. That said we need to decide if we want to do the move right now for the Eclipse extension. I think it&#39;s a good idea to do so and the strategy would be that any new extension/plugin or any component in the new architecture should be located in the 
org.xwiki package.&nbsp;What do others think?</div><div><br></div><div>I&#39;m going to commit it to xwiki-sandbox for now (till we have a maven2 build for it, then I&#39;ll move it to xwiki-extensions/eclipse) and we have already voted to give you access to it. 
</div></div></blockquote></span><div><br>Thanks a lot. We were thinking about moving into implementing the off-line operations asap, i think we need to take few design decisions upfront regarding off-line operations (mainly issues regarding synchronization). I&#39;ll make a post once we have thought about an initial idea so that we can optimize it on the dev list. 
<br></div><span class="q"><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div><div>I&#39;ll just need your ObjectWeb user id to give you write access. 
</div></div></blockquote></span><div><br>Tharindu - tharindujayasuriya<br>&nbsp;<br></div>Asiri - asiri<br><br>Thanks.<br><br>- Tharindu &amp; Asiri<div><span class="e" id="q_1143d09bff30710f_7"><br><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
 <div><div>Thanks</div><div>-Vincent</div><div><br><div><div><span><div>On Jul 31, 2007, at 2:45 PM, Vincent Massol wrote:</div><br></span></div><blockquote type="cite"><div><span> Hi Tharindu,<div><br></div><div>I&#39;ll review this latest patch later today or tomorrow. 
</div><div><br></div><div>Thanks</div><div>-Vincent</div><div><br><div><div>On Jul 28, 2007, at 7:32 PM, tharindu jayasuriya wrote: </div><br><blockquote type="cite">Hi All,<br><br>Attached are the latest sources and binaries of XEclipse m1. 
<br><br>Issues Fixed,<br><br>1. All Jigloo dependencies removed.<br><br>2. Code documentation improved according to instructions from Vincent. <br><br> 3. Back-End XML RPC&#39;s patched to suite XEclipse (Asiri)<br><br><a href="http://jira.xwiki.org/jira/browse/XWIKI-1520" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
 http://jira.xwiki.org/jira/browse/XWIKI-1520 </a><br><br><a href="http://jira.xwiki.org/jira/browse/XWIKI-1521" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)"> http://jira.xwiki.org/jira/browse/XWIKI-1521 
</a><br><br><a href="http://jira.xwiki.org/jira/browse/XWIKI-1524" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)"> http://jira.xwiki.org/jira/browse/XWIKI-1524</a><br><br>Let&#39;s hope this would finalize XEclipse m1 ... :) 
<br> <br>Hoping to hear from you soon...<br><br>Thanks.<br><br>- Tharindu &amp; Asiri<br><br><div><span class="gmail_quote"> On 7/16/07, <b class="gmail_sendername">Vincent Massol</b> &lt;<a href="mailto:vincent@massol.net" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
 vincent@massol.net </a>&gt; wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div>Hi Tharindu,<div><br></div><div>I have done a first pass on the code review and I have a few comments: 
</div><div><br></div><div>1) You seem to have use Cloudgarden&#39;s Jigloo and unfortunately the license isn&#39;t good enough for us so we cannot use it... Here&#39;s what it says in the generated file: </div><div><br></div>
 <div>/**</div><div> * This code was edited or generated using CloudGarden&#39;s Jigloo SWT/Swing GUI Builder, which is free</div><div> * for non-commercial use. If Jigloo is being used commercially (ie, by a corporation, company or 
</div><div> * business for any purpose whatever) then you should purchase a license for each developer using</div><div> * Jigloo. Please visit <a href="http://www.cloudgarden.com" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
 www.cloudgarden.com</a> for details. Use of Jigloo implies acceptance of these</div><div> * licensing terms. A COMMERCIAL LICENSE HAS NOT BEEN PURCHASED FOR THIS MACHINE, SO JIGLOO OR THIS</div><div> * CODE CANNOT BE USED LEGALLY FOR ANY CORPORATE OR COMMERCIAL PURPOSE. 
</div><div> */</div><div><br></div><div>We cannot use Jigloo because we want commercial companies using XWiki under the LGPL license. Thus we cannot commit this code.</div><div><br></div><div>Could you find some alternative? The UI doesn&#39;t seem too complex so I should be easy to do it by hand I think. 
</div><div><br></div><div>2) Thanks for your javadoc. It&#39;s nice and helps a lot. However it can be improved,&nbsp;especially for Classes. This is the most important Javadoc and should answer the question &quot;what is the class for?&quot;.&nbsp; 
</div><div><br></div><div>Also please see:</div><div><font size="3"><span style="font-size: 12px;"><a href="http://www.xwiki.org/xwiki/bin/view/Community/CodeStyle#HDonotuse27public27ininterfaces" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
 http://www.xwiki.org/xwiki/bin/view/Community/CodeStyle#HDonotuse27public27ininterfaces</a></span></font></div><div><font size="3"><span style="font-size: 12px;"><a href="http://www.xwiki.org/xwiki/bin/view/Community/CodeStyle#HDonotduplicatemethodcommentswithparameterscomments" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
 http://www.xwiki.org/xwiki/bin/view/Community/CodeStyle#HDonotduplicatemethodcommentswithparameterscomments</a></span></font><font size="3"><span style="font-size: 12px;"></span></font></div><div><font size="3"><span style="font-size: 12px;">
 <br></span></font></div><div>Parameters and return value shouldn&#39;t start with &quot;-&quot; in javadoc. See the Sun&#39;s Javadoc coding conventions.</div><div><br></div><div>3) Please add copyright to all classes and don&#39;t use the @author tag. Instead we&#39;ll add Asiri and yourself to the Hall of Fame + in the SVN commits. 
</div><div><br></div><div>The rest sounds good. We need to add maven build of course. I&#39;ll start looking into that after we fix the points above.</div><div><br></div><div>Also, I haven&#39;t coded plugins in Eclipse for a very very long time so I have no idea if what you&#39;ve done is the right way of doing it so I&#39;ll assume it is :-) 
</div><div><br></div><div>Thanks again and keep up the good work!&nbsp;</div><div>-Vincent</div><div><br><div><div><span><div>On Jul 15, 2007, at 10:04 AM, tharindu jayasuriya wrote:</div><br> </span></div><blockquote type="cite">
 <div><span>Hi all,<br><br>This is about r.1.0.m1 version of xeclipse (XWiki-Eclipse-Plugin).<br><br>We have completed following tasks in this release, <br><br>1. Cleaned up source code ( need to be confirmed by Vincent ) 
<br> <br>2. Implemented adding/deleting pages. <br><br>&nbsp;&nbsp;&nbsp; - Adding pages does not seem to work correctly due to some errors in XML-RPC implementation of XWiki, need to look into this. <br>&nbsp;&nbsp;&nbsp; - Removing pages does not work at all because the corresponding XML-RPC is not implemented in XWiki. 
<br><br>3. Implemented adding/deleting spaces.<br><br>&nbsp;&nbsp; - Adding spaces work fine.<br>&nbsp;&nbsp; - Deleting spaces does not work (RPC not implemented in XWiki) <br><br>As it&#39;s obvious by now, we need to peek into XWiki internals to get these issues fixed. But since we have a scheduled release today (and these issues showed up all of a sudden), we thought of finishing the work from the plugin&#39;s end and uploading the relevant work. Anyway, those issues need to be fixed asap. 
<br><br>We have tested the work on a stand alone (HSQLDB) Xwiki installation, it would be really nice if someone can test the plugin on a real server and confirm the results :)<br><br>Vincent, I couldn&#39;t find an appropriate place to upload the files in XWIKI JIRA, so i thought of attaching relevant files into this email. I&#39;m really sorry for any inconveniences. 
<br><br>Hope to hear from you very soon.<br><br>Thanks a lot!<br><br>- Tharindu &amp; Asiri<br><br></span></div></blockquote></div></div></div></blockquote></div></blockquote></div></div></span></div></blockquote></div></div>
</div></blockquote></span></div></div><br></blockquote></div><br></div></span></div></div></div></blockquote></div><br></blockquote></div><br></div></div><br><br>--<br>You receive this message as a subscriber of the <a onclick="return top.js.OpenExtLink(window,event,this)" href="mailto:xwiki-dev@objectweb.org">
xwiki-dev@objectweb.org</a> mailing list.<br>To unsubscribe: mailto:<a onclick="return top.js.OpenExtLink(window,event,this)" href="mailto:xwiki-dev-unsubscribe@objectweb.org">xwiki-dev-unsubscribe@objectweb.org</a><br>For general help: mailto:
<a onclick="return top.js.OpenExtLink(window,event,this)" href="mailto:sympa@objectweb.org">sympa@objectweb.org</a>?subject=help<br>ObjectWeb mailing lists service home page: <a onclick="return top.js.OpenExtLink(window,event,this)" href="http://www.objectweb.org/wws" target="_blank">
http://www.objectweb.org/wws</a><br><br></blockquote></div><br>