27 Jul
2008
27 Jul
'08
2:39 p.m.
On 26 juil. 08, at 20:45, malaka ekanayake wrote:
Hi all,
Now I've completed (committed to the sandbox) the syntax colouring
for most of the Velocity syntax. The colours used are not yet
finalized. We are yet to develop colour scheme for both Xiki and
Velocity syntax. Your suggestions for appropriate colours are welcome.
I am not a graphic designer so I will not have suggestions for the
color schemes.
From an engineering point of view, it is clear that a some point the
color scheme must be configurable and not hard-coded into the source
code (see ColorProvider). This is not too difficult and we can leave
it out for later, once all the other functionalities will be
implemented (i.e., let's give this feature a low priority for now).
I've identified following tasks which are to be
completed.
1) support for user defined macros in Velocity
2) Enhance the Xwiki content assistance.
3) Implement the Velocity content assistance
4) Implement the Xwiki and Velocity error handling
AFAIS, for the 4th task we have to integrate Xwiki and Velocity
parsers to get the error messages and to find the excat location of
the error. Your comments are welcom on this.
This is indeed a good idea. So we can take advantage of the velocity
parser output in order to put error markers and messages in the
editor. However I don't know the Velocity parser's API and the
granularity of its error messages. So this might require a bit of
investigation. I suggest you to spend some time (i.e., not more than a
day) on this topic, since it will bring a nice feature in.
I would prioritize your task list in the following way: 3,4,2,1
By the way, what are the enhancements to the content assistance you
would like to target?
I would like to suggest following changes to the
existing package
sturcture of xeclipse plugin. Now this editor plugin supports
different languages, I think refactoring of the package stucture is
needed. For the moment, I've included Velocity related classes under
the following package name.
org.xwiki.eclipse.ui.editors.velocity.*
And also several other classes has been modified provide syntax
coloring for Velocity. So my suggetion is to put all the Xwiki
related classes under the following package name.
org.xwiki.eclipse.ui.editors.xwiki.*
Then the common classes can be put in the
org.org.xwiki.eclipse.ui.editors and
org.xwiki.eclipse.ui.editors.util packages.
Not sure... org.xwiki.eclipse.ui.editors.xwiki.* is a bit weird
because org.xwiki.eclipse.ui.editors already suggests that the editors
we are talking about are about xwiki, so
org.xwiki.eclipse.ui.editors.xwiki.* seems rather redundant. Maybe
org.xwiki.eclipse.ui.editors.default.* is a better name. Anyway I see
your point and I agree. Let's think about it.
Finally, thank you for the good job! :)
Cheers,
Fabio