Re: [xwiki-devs] [VOTE] Change search id to class to fix invalid XHTML/WCAG + various other changes

Hi, Whenever a panel is displayed more than once (ie on the panel page itself if the page is also displayed in a panel column, in the panel wizard, etc) we have invalid XHTML for panels that use an HTML ID attribute. We have this in the search panel right now which I'd like to fix. In addition with Colibri we've hardcoded the search panel content in the header. Here's what I'd like to do: 1) Use class name of globalsearch and globalsearchinput instead of IDs

Note: WCAG tests forbid using<label> without a FOR attribute which means we need an ID for the input. This can be achieved easily using velocity to increment a counter. This is a technical internal ID anyway so it won't matter. 2) In Colibri, use #displaypanel(Panels.Search) instead of hardcoding the panel content in the header. This allow users to edit the content for example to change the link to Main/Websearch to Main/LuceneSearch or do any other thing). Note: the only change between what is currently in the Search panel and in the colibri header is the image which can be overwritten in colibri I guess. A better solution (if someone with CSS skills can help me) might be to define the image to display in the CSS.

3) In the release notes, mention the change and tell users that if they want to keep the old behavior (for ex if they have a custom skin using the globalsearch* IDs) then they just need to edit the Search panel and replace "class" by "id". Here's my +1