16 Apr
2010
16 Apr
'10
2:10 p.m.
Thanks for your remarks, Caty.
I'll add the modifications in a new patch.
Raluca.
On Fri, Apr 16, 2010 at 1:59 PM, Ecaterina Valica <valicac(a)gmail.com> wrote:
Hi Raluca,
Looks good. Some remarks:
*__A__ *
div.datepicker table tbody tr td.nclick_outbound,
div.datepicker table tbody tr td.nclick_outbound:hover {
color: $theme.backgroundSecondaryColor;
}
should be
color: $theme.textSecondaryColor;
because it's a text color.
*__B__*
every "0px" should be "0" simple;
*__C__*
div.datepicker {
font-family: arial;
font-size: 10px;
}
our default is
font-family:sans-serif;
and also, we should use relative font sizes (em, %) instead of "px".
*__D__*
and if you want me to be very picky :P you could use
font-weight: 400; instead of normal
*__E__*
Also the inline styles, like for:
<datepicker-mydate_id-prev style="cursor: pointer;"> should be integrated
in
the css.
*__F__*
you should remove the
filter:alpha(Opacity=0); for the IE
Hope this review is helpful,
Caty
On Fri, Apr 16, 2010 at 12:53, Raluca Stavro <raluca.morosan(a)xwiki.com>wrote;wrote:
Hello devs,
I would like to contribute to the DatePicker application.
Currently, the DatePicker stylesheet does not take in account the
color theme. This is why I created a Jira issue (XCONTRIB-109) and I
attached a patch to it. You will see some screenshots with the new
styles applied on the DatePicker table.
Can someone please give me the right to commit those styles?
Raluca.
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs