[xwiki-devs] VOTE: Integrate LESS in XWiki

List overview All Threads
Download

newer

older

[xwiki-devs] [Contrib] Create a...

[xwiki-devs] [History] Add links...

Guillaume "Louis-Marie" Delhumeau

15 May 2014 15 May '14

12:03 p.m.

Needs: As you already know, the new skin, Flamingo, is based on Bootstrap ( http://getbootstrap.com/) which use a CSS Preprocessor to have more flexibility. There is 2 majors competitors in this field: LESS ( http://lesscss.org/) and SASS (http://sass-lang.com/). Bootstrap is using LESS but they also provide an official port for SASS. We need to execute one of these preprocessors at the runtime, to recompile the Bootstrap CSS according to the current Color Theme. After a long thread [1] where we have compared the 2 preprocessors, and after some discussions on IRC, **I am proposing you to choose LESS**. Why: * It is the original preprocessor used by Bootstrap, and so the majority of Bootstrap Themes that we can find on the web provides LESS sources. If we want to be able to use all these themes, using LESS is clearly an advantage. * Caty, Denis and I have a bit of experience with it. Bluebird [2], Junco [3] and the current Flamingo skins are built with LESS. * The syntax is not too close to Velocity, meanwhile SASS is. * The Java integration, using Rhino, works quite well. Although there is an issue [4] for which I have written a patch. I hope the LESS community will handle it. * It looks a bit more popular than SASS. Here is my +1 for using LESS. For the record, this is what I am going to do: * Implement a cache to only compile LESS files when needed, because the computation is costly. The cache will be flushed only when the current color theme is modified. * Write new components and a script service to compile LESS files that are present in the skin directory, partially parsed with Velocity. In the future, we might want to integrate it directly in the Skin Action, but that means we need to change oldcore. Thanks, Guillaume (Louis-Marie) --- [1] The thread "[Proposal] Integrate LESS css in XWiki": http://markmail.org/message/hw45txkv2vk5dnqw [2] Bluebird Skin: http://extensions.xwiki.org/xwiki/bin/view/Extension/Bluebird+Skin [3] Junco Skin: http://extensions.xwiki.org/xwiki/bin/view/Extension/Junco+Skin [4] LESS issue: https://github.com/less/less.js/issues/2005

Show replies by date

Ecaterina Moraru (Valica)

15 May 15 May

12:51 p.m.

+1 for LESS Thanks, Caty On Thu, May 15, 2014 at 1:03 PM, Guillaume "Louis-Marie" Delhumeau < gdelhumeau(a)xwiki.com> wrote:

...

Denis Gervalle

2:41 p.m.

+1 On Thu, May 15, 2014 at 12:51 PM, Ecaterina Moraru (Valica) < valicac(a)gmail.com> wrote:

...

+1 for LESS Thanks, Caty On Thu, May 15, 2014 at 1:03 PM, Guillaume "Louis-Marie" Delhumeau < gdelhumeau(a)xwiki.com> wrote:

Needs: As you already know, the new skin, Flamingo, is based on

Bootstrap (

http://getbootstrap.com/) which use a CSS Preprocessor to have more flexibility. There is 2 majors competitors in this field: LESS ( http://lesscss.org/) and SASS (http://sass-lang.com/). Bootstrap is

using

LESS but they also provide an official port for SASS. We need to execute one of these preprocessors at the runtime, to

recompile

the Bootstrap CSS according to the current Color Theme. After a long thread [1] where we have compared the 2 preprocessors, and after some discussions on IRC, **I am proposing you to choose LESS**. Why: * It is the original preprocessor used by Bootstrap, and so the majority

Bootstrap Themes that we can find on the web provides LESS sources. If we want to be able to use all these themes, using LESS is clearly an advantage. * Caty, Denis and I have a bit of experience with it. Bluebird [2], Junco [3] and the current Flamingo skins are built with LESS. * The syntax is not too close to Velocity, meanwhile SASS is. * The Java integration, using Rhino, works quite well. Although there is

issue [4] for which I have written a patch. I hope the LESS community

will

handle it. * It looks a bit more popular than SASS. Here is my +1 for using LESS. For the record, this is what I am going to do: * Implement a cache to only compile LESS files when needed, because the computation is costly. The cache will be flushed only when the current color theme is modified. * Write new components and a script service to compile LESS files that

are

present in the skin directory, partially parsed with Velocity. In the future, we might want to integrate it directly in the Skin Action, but

that

means we need to change oldcore. Thanks, Guillaume (Louis-Marie) --- [1] The thread "[Proposal] Integrate LESS css in XWiki": http://markmail.org/message/hw45txkv2vk5dnqw [2] Bluebird Skin: http://extensions.xwiki.org/xwiki/bin/view/Extension/Bluebird+Skin [3] Junco Skin: http://extensions.xwiki.org/xwiki/bin/view/Extension/Junco+Skin [4] LESS issue: https://github.com/less/less.js/issues/2005 _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

_______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

-- Denis Gervalle SOFTEC sa - CEO

vincent＠massol.net

2:46 p.m.

+1 Thanks -Vincent On 15 May 2014 at 12:04:17, Guillaume Louis-Marie Delhumeau (gdelhumeau@xwiki.com(mailto:gdelhumeau@xwiki.com)) wrote:

...

Thomas Mortagne

4:26 p.m.

+1 On Thu, May 15, 2014 at 12:03 PM, Guillaume "Louis-Marie" Delhumeau <gdelhumeau(a)xwiki.com> wrote:

...

-- Thomas Mortagne

Marius Dumitru Florea

6:48 p.m.

+1 Thanks, Marius On Thu, May 15, 2014 at 1:03 PM, Guillaume "Louis-Marie" Delhumeau <gdelhumeau(a)xwiki.com> wrote:

...

Guillaume "Louis-Marie" Delhumeau

19 May 19 May

11:42 a.m.

6 +1, no -1, the vote is passed. Thanks! 2014-05-15 18:48 GMT+02:00 Marius Dumitru Florea < mariusdumitru.florea(a)xwiki.com>gt;:

...

+1 Thanks, Marius On Thu, May 15, 2014 at 1:03 PM, Guillaume "Louis-Marie" Delhumeau <gdelhumeau(a)xwiki.com> wrote:

Needs: As you already know, the new skin, Flamingo, is based on

Bootstrap (

using

LESS but they also provide an official port for SASS. We need to execute one of these preprocessors at the runtime, to

recompile

Bootstrap Themes that we can find on the web provides LESS sources. If we want to be able to use all these themes, using LESS is clearly an

advantage.

* Caty, Denis and I have a bit of experience with it. Bluebird [2], Junco [3] and the current Flamingo skins are built with LESS. * The syntax is not too close to Velocity, meanwhile SASS is. * The Java integration, using Rhino, works quite well. Although there is

issue [4] for which I have written a patch. I hope the LESS community

will

are

present in the skin directory, partially parsed with Velocity. In the future, we might want to integrate it directly in the Skin Action, but

that

_______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

Guillaume "Louis-Marie" Delhumeau

21 May 21 May

10:07 a.m.

Thanks to this, Flamingo will now be able to support the old color-themes! Screenshots: http://xwiki.kephpage.net/flamingo/flamingo-default.png http://xwiki.kephpage.net/flamingo/flamingo-dusk.png http://xwiki.kephpage.net/flamingo/flamingo-mint.png http://xwiki.kephpage.net/flamingo/flamingo-ruby.png http://xwiki.kephpage.net/flamingo/flamingo-nocolortheme.png I'll commit it for 6.1M2. Now, my plan is to write a new Color Theme Editor to be able to edit things specific to this skin, create new color themes based upon http://bootswatch.com/ and work again on the skin to look closer to the initial proposal (with an appbar, etc...). Thanks, Guillaume 2014-05-19 11:42 GMT+02:00 Guillaume "Louis-Marie" Delhumeau < gdelhumeau(a)xwiki.com>gt;:

...

6 +1, no -1, the vote is passed. Thanks! 2014-05-15 18:48 GMT+02:00 Marius Dumitru Florea < mariusdumitru.florea(a)xwiki.com>gt;: +1

Thanks, Marius On Thu, May 15, 2014 at 1:03 PM, Guillaume "Louis-Marie" Delhumeau <gdelhumeau(a)xwiki.com> wrote:

Needs: As you already know, the new skin, Flamingo, is based on

Bootstrap (

using

LESS but they also provide an official port for SASS. We need to execute one of these preprocessors at the runtime, to

recompile

majority of

Bootstrap Themes that we can find on the web provides LESS sources. If

want to be able to use all these themes, using LESS is clearly an

advantage.

* Caty, Denis and I have a bit of experience with it. Bluebird [2],

Junco

[3] and the current Flamingo skins are built with LESS. * The syntax is not too close to Velocity, meanwhile SASS is. * The Java integration, using Rhino, works quite well. Although there

is an

issue [4] for which I have written a patch. I hope the LESS community

will

are

present in the skin directory, partially parsed with Velocity. In the future, we might want to integrate it directly in the Skin Action, but

that

_______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

vincent＠massol.net

3:53 p.m.

On 21 May 2014 at 10:08:34, Guillaume Louis-Marie Delhumeau (gdelhumeau@xwiki.com(mailto:gdelhumeau@xwiki.com)) wrote:

...

Cool! I’m also eager to see a "Favorite Applications” panel and a “All Applications” panel that can both scale on small and medium panel widths. We also need to decide how the Application Index will be implemented in Flamingo too :) Thanks -Vincent

...

Thanks, Guillaume 2014-05-19 11:42 GMT+02:00 Guillaume "Louis-Marie" Delhumeau < gdelhumeau(a)xwiki.com>gt;: > 6 +1, no -1, the vote is passed. > > Thanks! > > > 2014-05-15 18:48 GMT+02:00 Marius Dumitru Florea < > mariusdumitru.florea(a)xwiki.com>gt;: > > +1 >> >> Thanks, >> Marius >> >> On Thu, May 15, 2014 at 1:03 PM, Guillaume "Louis-Marie" Delhumeau >> wrote: >> > Needs: As you already know, the new skin, Flamingo, is based on >> Bootstrap ( >> > http://getbootstrap.com/) which use a CSS Preprocessor to have more >> > flexibility. There is 2 majors competitors in this field: LESS ( >> > http://lesscss.org/) and SASS (http://sass-lang.com/). Bootstrap is >> using >> > LESS but they also provide an official port for SASS. >> > >> > We need to execute one of these preprocessors at the runtime, to >> recompile >> > the Bootstrap CSS according to the current Color Theme. >> > >> > After a long thread [1] where we have compared the 2 preprocessors, and >> > after some discussions on IRC, **I am proposing you to choose LESS**. >> > >> > Why: >> > * It is the original preprocessor used by Bootstrap, and so the >> majority of >> > Bootstrap Themes that we can find on the web provides LESS sources. If >> we >> > want to be able to use all these themes, using LESS is clearly an >> advantage. >> > * Caty, Denis and I have a bit of experience with it. Bluebird [2], >> Junco >> > [3] and the current Flamingo skins are built with LESS. >> > * The syntax is not too close to Velocity, meanwhile SASS is. >> > * The Java integration, using Rhino, works quite well. Although there >> is an >> > issue [4] for which I have written a patch. I hope the LESS community >> will >> > handle it. >> > * It looks a bit more popular than SASS. >> > >> > Here is my +1 for using LESS. >> > >> > For the record, this is what I am going to do: >> > >> > * Implement a cache to only compile LESS files when needed, because the >> > computation is costly. The cache will be flushed only when the current >> > color theme is modified. >> > * Write new components and a script service to compile LESS files that >> are >> > present in the skin directory, partially parsed with Velocity. In the >> > future, we might want to integrate it directly in the Skin Action, but >> that >> > means we need to change oldcore. >> > >> > Thanks, >> > >> > Guillaume (Louis-Marie) >> > >> > --- >> > [1] The thread "[Proposal] Integrate LESS css in XWiki": >> > http://markmail.org/message/hw45txkv2vk5dnqw >> > [2] Bluebird Skin: >> > http://extensions.xwiki.org/xwiki/bin/view/Extension/Bluebird+Skin >> > [3] Junco Skin: >> > http://extensions.xwiki.org/xwiki/bin/view/Extension/Junco+Skin >> > [4] LESS issue: https://github.com/less/less.js/issues/2005

4181

days inactive

4187

days old

xwiki-devs@xwiki.org

Manage subscription

8 comments

6 participants

tags (0)

participants (6)

Denis Gervalle
Ecaterina Moraru (Valica)
Guillaume "Louis-Marie" Delhumeau
Marius Dumitru Florea
Thomas Mortagne
vincent＠massol.net