[xwiki-devs] [Proposal][NestedSpaces] Deprecate and Remove new DocumentReference(wiki, space, page) constructor
17 Jun
2015
17 Jun
'15
9:57 a.m.
Hi devs,
Ideally I believe we should remove the new DocumentReference(wiki, space, page)
constructor. However, for backward compatibility we cannot do this.
So I propose that we start by deprecating it as we should now always use the new
DocumentReference(wiki, List<String> spaces, page) one.
What I suggest we do to flesh out all issues related to Nested Spaces, is to start by
removing it on our dev machines to find out places to fix.
Then once we’ve progressed enough to not break everything, I suggest we move it to Legacy
with an Aspect to make sure we don’t use it anymore.
WDYT?
Thanks
-Vincent
17 Jun
17 Jun
9:59 a.m.
Sounds fine to me.
On 17/06/2015 09:57, vincent(a)massol.net wrote:
Hi devs,
Ideally I believe we should remove the new DocumentReference(wiki, space, page)
constructor. However, for backward compatibility we cannot do this.
So I propose that we start by deprecating it as we should now always use the new
DocumentReference(wiki, List<String> spaces, page) one.
What I suggest we do to flesh out all issues related to Nested Spaces, is to start by
removing it on our dev machines to find out places to fix.
Then once we’ve progressed enough to not break everything, I suggest we move it to Legacy
with an Aspect to make sure we don’t use it anymore.
WDYT?
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Jean Simard
jean.simard(a)xwiki.com
Research engineer at XWiki SAS
http://www.xwiki.com
Committer on the XWiki.org project
http://www.xwiki.org
10:02 a.m.
We also need to do the same for:
public DocumentReference createDocumentReference(String wiki, String space, String
page)
FTR:
* 1300 places to fix in Java using new DocumentReference(wiki, space, page)
* 90 places using $services.model.createDocumentReference(…) in *.vm
* 140 places using $services.model.createDocumentReference(…) in *.xml
That’s a lot…
Thanks
-Vincent
On 17 Jun 2015 at 09:57:38, vincent(a)massol.net (vincent(a)massol.net) wrote:
Hi devs,
Ideally I believe we should remove the new DocumentReference(wiki, space, page)
constructor. However, for backward compatibility we cannot do this.
So I propose that we start by deprecating it as we should now always use the new
DocumentReference(wiki, List<String> spaces, page) one.
What I suggest we do to flesh out all issues related to Nested Spaces, is to start by
removing it on our dev machines to find out places to fix.
Then once we’ve progressed enough to not break everything, I suggest we move it to Legacy
with an Aspect to make sure we don’t use it anymore.
WDYT?
Thanks
-Vincent
10:03 a.m.
On 17/06/2015 10:02, vincent(a)massol.net wrote:
We also need to do the same for:
public DocumentReference createDocumentReference(String wiki, String space, String
page)
FTR:
* 1300 places to fix in Java using new DocumentReference(wiki, space, page)
* 90 places using $services.model.createDocumentReference(…) in *.vm
* 140 places using $services.model.createDocumentReference(…) in *.xml
That’s a lot…
Yes but IntelliJ and sed are your friends ;-)
Thanks
-Vincent
On 17 Jun 2015 at 09:57:38, vincent(a)massol.net (vincent(a)massol.net) wrote:
Hi devs,
Ideally I believe we should remove the new DocumentReference(wiki, space, page)
constructor. However, for backward compatibility we cannot do this.
So I propose that we start by deprecating it as we should now always use the new
DocumentReference(wiki, List<String> spaces, page) one.
What I suggest we do to flesh out all issues related to Nested Spaces, is to start by
removing it on our dev machines to find out places to fix.
Then once we’ve progressed enough to not break everything, I suggest we move it to Legacy
with an Aspect to make sure we don’t use it anymore.
WDYT?
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Jean Simard
jean.simard(a)xwiki.com
Research engineer at XWiki SAS
http://www.xwiki.com
Committer on the XWiki.org project
http://www.xwiki.org
10:07 a.m.
On 17 Jun 2015 at 10:04:00, Jean SIMARD (jean.simard(a)xwiki.com) wrote:
On 17/06/2015 10:02, vincent(a)massol.net wrote:
We also need to do the same for:
public DocumentReference createDocumentReference(String wiki, String space, String page)
FTR:
* 1300 places to fix in Java using new DocumentReference(wiki, space, page)
* 90 places using $services.model.createDocumentReference(…) in *.vm
* 140 places using $services.model.createDocumentReference(…) in *.xml
That’s a lot…
Yes but IntelliJ and sed are your friends ;-)
Unfortunately not that simple… there’s no automatic fix.
-Vincent
Thanks
-Vincent
On 17 Jun 2015 at 09:57:38, vincent(a)massol.net (vincent(a)massol.net) wrote:
Hi devs,
Ideally I believe we should remove the new DocumentReference(wiki, space, page)
constructor. However, for backward compatibility we cannot do this.
So I propose that we start by deprecating it as we should now always use the new
DocumentReference(wiki, List<String> spaces, page) one.
What I suggest we do to flesh out all issues related to Nested Spaces, is to start by
removing it on our dev machines to find out places to fix.
Then once we’ve progressed enough to not break everything, I suggest we move it to Legacy
with an Aspect to make sure we don’t use it anymore.
WDYT?
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Jean Simard
jean.simard(a)xwiki.com
Research engineer at XWiki SAS
http://www.xwiki.com
Committer on the XWiki.org project
http://www.xwiki.org
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
1:24 p.m.
+1. We don`t have much choice in this anyway.
Thanks,
Eduard
On Wed, Jun 17, 2015 at 11:07 AM, vincent(a)massol.net <vincent(a)massol.net>
wrote:
On 17 Jun 2015 at 10:04:00, Jean SIMARD (jean.simard(a)xwiki.com) wrote:
On 17/06/2015 10:02, vincent(a)massol.net wrote:
We also need to do the same for:
public DocumentReference createDocumentReference(String wiki, String
space, String
page)
FTR:
* 1300 places to fix in Java using new DocumentReference(wiki, space,
page)
* 90 places using
$services.model.createDocumentReference(…) in *.vm
* 140 places using $services.model.createDocumentReference(…) in *.xml
That’s a lot…
Yes but IntelliJ and sed are your friends ;-)
Unfortunately not that simple… there’s no automatic fix.
-Vincent
Thanks
-Vincent
On 17 Jun 2015 at 09:57:38, vincent(a)massol.net (vincent(a)massol.net)
wrote:
Hi devs,
Ideally I believe we should remove the new DocumentReference(wiki,
space, page)
constructor. However, for backward compatibility we cannot do
this.
So I propose that we start by deprecating it as we should now always use
the new
DocumentReference(wiki, List<String> spaces, page) one.
What I suggest we do to flesh out all issues related to Nested Spaces,
is to start
by removing it on our dev machines to find out places to fix.
Then once we’ve progressed enough to not break everything, I suggest we
move it to
Legacy with an Aspect to make sure we don’t use it anymore.
WDYT?
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Jean Simard
jean.simard(a)xwiki.com
Research engineer at XWiki SAS
http://www.xwiki.com
Committer on the XWiki.org project
http://www.xwiki.org
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
5:57 p.m.
+1
2015-06-17 13:24 GMT+02:00 Eduard Moraru <enygma2002(a)gmail.com>om>:
+1. We don`t have much choice in this anyway.
Thanks,
Eduard
On Wed, Jun 17, 2015 at 11:07 AM, vincent(a)massol.net <vincent(a)massol.net>
wrote:
--
Guillaume Delhumeau (gdelhumeau(a)xwiki.com)
Research & Development Engineer at XWiki SAS
Committer on the XWiki.org project
On 17 Jun 2015 at 10:04:00, Jean SIMARD (jean.simard(a)xwiki.com) wrote:
On 17/06/2015 10:02, vincent(a)massol.net wrote:
do
We also need to do the same for:
public DocumentReference createDocumentReference(String wiki, String
space, String
page)
FTR:
* 1300 places to fix in Java using new DocumentReference(wiki, space,
page)
* 90 places using
$services.model.createDocumentReference(…) in *.vm
* 140 places using $services.model.createDocumentReference(…) in *.xml
That’s a lot…
Yes but IntelliJ and sed are your friends ;-)
Unfortunately not that simple… there’s no automatic fix.
-Vincent
Thanks
-Vincent
On 17 Jun 2015 at 09:57:38, vincent(a)massol.net (vincent(a)massol.net)
wrote:
Hi devs,
Ideally I believe we should remove the new DocumentReference(wiki,
space, page)
constructor. However, for backward compatibility we cannot this.
>
> So I propose that we start by deprecating it as we should now always
use
the new DocumentReference(wiki,
List<String> spaces, page) one.
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
What I suggest we do to flesh out all issues related to Nested Spaces,
is to start
by removing it on our dev machines to find out places to fix.
Then once we’ve progressed enough to not break everything, I suggest we
move it to
Legacy with an Aspect to make sure we don’t use it anymore.
WDYT?
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Jean Simard
jean.simard(a)xwiki.com
Research engineer at XWiki SAS
http://www.xwiki.com
Committer on the XWiki.org project
http://www.xwiki.org
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
18 Jun
18 Jun
1:18 p.m.
+1
Thanks,
Marius
On Wed, Jun 17, 2015 at 10:57 AM, vincent(a)massol.net <vincent(a)massol.net> wrote:
Hi devs,
Ideally I believe we should remove the new DocumentReference(wiki, space, page)
constructor. However, for backward compatibility we cannot do this.
So I propose that we start by deprecating it as we should now always use the new
DocumentReference(wiki, List<String> spaces, page) one.
What I suggest we do to flesh out all issues related to Nested Spaces, is to start by
removing it on our dev machines to find out places to fix.
Then once we’ve progressed enough to not break everything, I suggest we move it to Legacy
with an Aspect to make sure we don’t use it anymore.
WDYT?
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
3378
days inactive
3379
days old
7 comments
5 participants
participants (5)
-
Eduard Moraru -
Guillaume "Louis-Marie" Delhumeau -
Jean SIMARD -
Marius Dumitru Florea -
vincent＠massol.net