Re: [xwiki-devs] [xwiki-notifications] r29712 - platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/LDAP - xwiki-devs@xwiki.org

24 Jun 2010

On Jun 24, 2010, at 5:47 PM, tmortagne (SVN) wrote:

...
  Author: tmortagne
 Date: 2010-06-24 17:47:15 +0200 (Thu, 24 Jun 2010)
 New Revision: 29712

 Modified:

platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/LDAP/XWikiLDAPAuthServiceImpl.java
 Log:
 [misc] More useful debug log

 Modified:
platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/LDAP/XWikiLDAPAuthServiceImpl.java
 ===================================================================
 ---
platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/LDAP/XWikiLDAPAuthServiceImpl.java	2010-06-24
15:43:19 UTC (rev 29711)
 +++
platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/LDAP/XWikiLDAPAuthServiceImpl.java	2010-06-24
15:47:15 UTC (rev 29712)
 @@ -416,6 +416,10 @@
         if ("1".equals(config.getLDAPParam("ldap_validate_password",
"0", context))) {
             String passwordField = config.getLDAPParam("ldap_password_field",
"userPassword", context);
             if (!connector.checkPassword(ldapDn, password, passwordField)) {
 +                LOG.debug("Password comparision failed, are you really sure you
need validate_password ?" + 
typo: comparison.

-Vincent

...
  +                    " If you don't enable it
it does not mean use credentiel are not validated." +
 +                    " The goal of this property is to bypass standard LDAP
bind.");
 +                
                 throw new XWikiException(XWikiException.MODULE_XWIKI_USER,
XWikiException.ERROR_XWIKI_USER_INIT,
                     "LDAP authentication failed:" + " could not validate
the password: wrong password for " + ldapDn);
             } 