Re: [xwiki-commits] r2393 - xwiki/branches/XWIKI_WYSIWYG_NEWARCHI/core/src/test/java/com/xpn/xwiki/wysiwyg
13 Mar
2007
13 Mar
'07
3:27 p.m.
Hi,
I'd say you should use lorem ipsum text, instead of real phrases.
And maybe this should be a general policy for all tests.
On 3/13/07, Christian Gmeiner <austriancoder(a)users.forge.objectweb.org>
wrote:
Author: austriancoder
Date: 2007-03-13 15:01:43 +0100 (Tue, 13 Mar 2007)
New Revision: 2393
Modified:
xwiki/branches/XWIKI_WYSIWYG_NEWARCHI/core/src/test/java/com/xpn/xwiki/wysiwyg/ConverterTest.java
Log:
* small updates
Modified:
xwiki/branches/XWIKI_WYSIWYG_NEWARCHI/core/src/test/java/com/xpn/xwiki/wysiwyg/ConverterTest.java
===================================================================
---
xwiki/branches/XWIKI_WYSIWYG_NEWARCHI/core/src/test/java/com/xpn/xwiki/wysiwyg/ConverterTest.java
2007-03-13 14:01:13 UTC (rev 2392)
+++
xwiki/branches/XWIKI_WYSIWYG_NEWARCHI/core/src/test/java/com/xpn/xwiki/wysiwyg/ConverterTest.java
2007-03-13 14:01:43 UTC (rev 2393)
@@ -14,7 +14,10 @@
assertEquals("__underline text__", result);
result =
Converter.convert("<strong>Hello</strong><em>dude</em><u>!</u>",
false);
- assertEquals("*Hello*~~dude~~__!__", result);
+ assertEquals("*Hello*~~dude~~__!__", result);
+
+ result =
Converter.convert("SomeFillText<strong>Hello</strong>SomeFillText<em>dude</em><u>!</u>SomeFillText",
false);
+
assertEquals("SomeFillText*Hello*SomeFillText~~dude~~__!__SomeFillText",
result);
}
public void testSubTagConversion()
@@ -23,6 +26,9 @@
assertEquals("*~~text~~*", result);
result =
Converter.convert("<strong><em>t<u>ex</u>t</em></strong>",
false);
- assertEquals("*~~t__ex__t~~*", result);
+ assertEquals("*~~t__ex__t~~*", result);
+
+ result = Converter.convert("<em>Lets hope this one
<strong>works
<u>too</u></strong>, and if not...</em>", false);
+ assertEquals("~~Lets hope this one *works __too__*, and if
not...~~", result);
}
}
--
http://purl.org/net/sergiu
13 Mar
13 Mar
3:36 p.m.
New subject: [xwiki-dev] Re: [xwiki-commits] r2393 - xwiki/branches/XWIKI_WYSIWYG_NEWARCHI/core/src/test/java/com/xpn/xwiki/wysiwyg
On 3/13/07, Sergiu Dumitriu <sergiu.dumitriu(a)gmail.com> wrote:
Hi,
I'd say you should use lorem ipsum text, instead of real phrases.
And maybe this should be a general policy for all tests.
What's wrong with having real text ?
Catalin
On 3/13/07, Christian Gmeiner
<austriancoder(a)users.forge.objectweb.org> wrote:
===================================================================
> result =
Converter.convert("<strong>Hello</strong><em>dude</em><u>!</u>",
false);
+
assertEquals("SomeFillText*Hello*SomeFillText~~dude~~__!__SomeFillText",
result);
> }
> public void
testSubTagConversion()
> @@ -23,6 +26,9 @@
> assertEquals("*~~text~~*", result);
> result =
Converter.convert("<strong><em>t<u>ex</u>t</em></strong>",
false);
--
http://purl.org/net/sergiu
--
You receive this message as a subscriber of the xwiki-dev(a)objectweb.org
mailing list.
To unsubscribe: mailto:xwiki-dev-unsubscribe@objectweb.org
For general help: mailto:sympa@objectweb.org?subject=help
ObjectWeb mailing lists service home page: http://www.objectweb.org/wws
Author: austriancoder
Date: 2007-03-13 15:01:43 +0100 (Tue, 13 Mar 2007)
New Revision: 2393
Modified:
xwiki/branches/XWIKI_WYSIWYG_NEWARCHI/core/src/test/java/com/xpn/xwiki/wysiwyg/ConverterTest.java
Log:
* small updates
Modified:
xwiki/branches/XWIKI_WYSIWYG_NEWARCHI/core/src/test/java/com/xpn/xwiki/wysiwyg/ConverterTest.java
---
xwiki/branches/XWIKI_WYSIWYG_NEWARCHI/core/src/test/java/com/xpn/xwiki/wysiwyg/ConverterTest.java
2007-03-13 14:01:13 UTC (rev 2392)
+++
xwiki/branches/XWIKI_WYSIWYG_NEWARCHI/core/src/test/java/com/xpn/xwiki/wysiwyg/ConverterTest.java
2007-03-13 14:01:43 UTC (rev 2393)
> @@ -14,7 +14,10 @@
> assertEquals("__underline text__", result);
-
assertEquals("*Hello*~~dude~~__!__", result);
+ assertEquals("*Hello*~~dude~~__!__", result);
+
+ result =
Converter.convert("SomeFillText<strong>Hello</strong>SomeFillText<em>dude</em><u>!</u>SomeFillText",
false);
- assertEquals("*~~t__ex__t~~*",
result);
+ assertEquals("*~~t__ex__t~~*", result);
+
+ result = Converter.convert("<em>Lets hope this one
<strong>works
<u>too</u></strong>, and if
not...</em>", false);
+ assertEquals("~~Lets hope this one
*works __too__*, and if
not...~~", result);
> }
> }
3:55 p.m.
New subject: [xwiki-dev] Re: [xwiki-commits] r2393 - xwiki/branches/XWIKI_WYSIWYG_NEWARCHI/core/src/test/java/com/xpn/xwiki/wysiwyg
On 3/13/07, Catalin Hritcu <catalin.hritcu(a)gmail.com> wrote:
On 3/13/07, Sergiu Dumitriu <sergiu.dumitriu(a)gmail.com> wrote:
I don't think that having "Dude, where's my car" in the source
code is a
good idea. It's not like the actual text makes the test work or fail, and
it's not like it gives a hint of what the test does. If the string explains
what the test is doing, then OK, put something meaningful in there. But
instead of random english words, it's better to use random lipsum words. At
least IMHO.
Sergiu
--
http://purl.org/net/sergiu
Hi,
I'd say you should use lorem ipsum text, instead of real phrases.
And maybe this should be a general policy for all tests.
What's wrong with having real text ?
Catalin
4:08 p.m.
New subject: [xwiki-dev] Re: [xwiki-commits] r2393 - xwiki/branches/XWIKI_WYSIWYG_NEWARCHI/core/src/test/java/com/xpn/xwiki/wysiwyg
t's not like the actual text makes the test work
or fail, and
it's not like it gives a hint of what the test does.
To see what the test does, have a look at the test method name.
If the string explains
what the test is doing, then OK, put something meaningful in there.
meaningful... ok.. somethink like:
<em>this is a test<strong>to check if subtags are
<u>working</></strong></em>
Do you really think that each of such a string should have a deeper meaning?
Greets,
austriancoder
4:08 p.m.
New subject: [xwiki-dev] Re: [xwiki-commits] r2393 - xwiki/branches/XWIKI_WYSIWYG_NEWARCHI/core/src/test/java/com/xpn/xwiki/wysiwyg
On 3/13/07, Sergiu Dumitriu <sergiu.dumitriu(a)gmail.com> wrote:
On 3/13/07, Catalin Hritcu
<catalin.hritcu(a)gmail.com> wrote:
Most people don't speak latin ... at least "Dude, where's my car" is
something we can understand.
Catalin
On 3/13/07, Sergiu Dumitriu
<sergiu.dumitriu(a)gmail.com> wrote:
I don't think that having "Dude, where's my car" in the source code is
a
good idea. It's not like the actual text makes the test work or fail, and
it's not like it gives a hint of what the test does. If the string explains
what the test is doing, then OK, put something meaningful in there. But
instead of random english words, it's better to use random lipsum words. At
least IMHO.
Hi,
I'd say you should use lorem ipsum text, instead of real phrases.
And maybe this should be a general policy for all tests.
What's wrong with having real text ?
Catalin
3:48 p.m.
New subject: [xwiki-dev] Re: [xwiki-commits] r2393 - xwiki/branches/XWIKI_WYSIWYG_NEWARCHI/core/src/test/java/com/xpn/xwiki/wysiwyg
On Mar 13, 2007, at 3:27 PM, Sergiu Dumitriu wrote:
Hi,
I'd say you should use lorem ipsum text, instead of real phrases.
Why? Also lorem ipsum doesn't contain HTML, does it?
-Vincent
And maybe this should be a general policy for all tests.
On 3/13/07, Christian Gmeiner
<austriancoder(a)users.forge.objectweb.org> wrote:
Author: austriancoder
Date: 2007-03-13 15:01:43 +0100 (Tue, 13 Mar 2007)
New Revision: 2393
Modified:
xwiki/branches/XWIKI_WYSIWYG_NEWARCHI/core/src/test/java/com/xpn/
xwiki/wysiwyg/ConverterTest.java
Log:
* small updates
Modified: xwiki/branches/XWIKI_WYSIWYG_NEWARCHI/core/src/test/java/
com/xpn/xwiki/wysiwyg/ConverterTest.java
===================================================================
--- xwiki/branches/XWIKI_WYSIWYG_NEWARCHI/core/src/test/java/com/
xpn/xwiki/wysiwyg/ConverterTest.java 2007-03-13 14:01:13 UTC (rev
2392)
+++ xwiki/branches/XWIKI_WYSIWYG_NEWARCHI/core/src/test/java/com/
xpn/xwiki/wysiwyg/ConverterTest.java 2007-03-13 14:01:43 UTC (rev
2393)
@@ -14,7 +14,10 @@
assertEquals("__underline text__", result);
result = Converter.convert("<strong>Hello</
strong><em>dude</em><u>!</u>", false);
- assertEquals("*Hello*~~dude~~__!__", result);
+ assertEquals("*Hello*~~dude~~__!__", result);
+
+ result = Converter.convert("SomeFillText<strong>Hello</
strong>SomeFillText<em>dude</em><u>!</u>SomeFillText",
false);
+ assertEquals("SomeFillText*Hello*SomeFillText~~dude~~__!
__SomeFillText", result);
}
public void testSubTagConversion()
@@ -23,6 +26,9 @@
assertEquals("*~~text~~*", result);
result =
Converter.convert("<strong><em>t<u>ex</u>t</em></
strong>", false);
- assertEquals("*~~t__ex__t~~*", result);
+ assertEquals("*~~t__ex__t~~*", result);
+
+ result = Converter.convert("<em>Lets hope this one
<strong>works <u>too</u></strong>, and if
not...</em>", false);
+ assertEquals("~~Lets hope this one *works __too__*, and if
not...~~", result);
}
}
4:05 p.m.
New subject: [xwiki-dev] Re: [xwiki-commits] r2393 - xwiki/branches/XWIKI_WYSIWYG_NEWARCHI/core/src/test/java/com/xpn/xwiki/wysiwyg
On 3/13/07, Vincent Massol <vincent(a)massol.net> wrote:
On Mar 13, 2007, at 3:27 PM, Sergiu Dumitriu wrote:
Hi,
I'd say you should use lorem ipsum text, instead of real phrases.
Why? Also lorem ipsum doesn't contain HTML, does it?
-Vincent
Real phrases don't contain HTML either. It's just a matter of what words do
we use. It's not that important, anyway, it was just a suggestion.
Sergiu
--
http://purl.org/net/sergiu
11:17 p.m.
New subject: [xwiki-dev] Re: [xwiki-commits] r2393 - xwiki/branches/XWIKI_WYSIWYG_NEWARCHI/core/src/test/java/com/xpn/xwiki/wysiwyg
When checking my email on my mobile phone, I was wondering (I mostly
look at mail subjects) what Christian had done wrong to trigger these
emails after his commit !
If we manage to go at this level of details in the test code then it's
looking good ;-)
Great to see some new code for the editor !
Ludovic
Sergiu Dumitriu a écrit :
On 3/13/07, *Vincent Massol* <vincent(a)massol.net
<mailto:vincent@massol.net>> wrote:
On Mar 13, 2007, at 3:27 PM, Sergiu Dumitriu wrote:
--
Ludovic Dubost
Blog: http://www.ludovic.org/blog/
XWiki: http://www.xwiki.com
Skype: ldubost GTalk: ldubost
AIM: nvludo Yahoo: ludovic
Hi,
I'd say you should use lorem ipsum text, instead of real phrases.
Why? Also lorem ipsum doesn't contain HTML, does it?
-Vincent
Real phrases don't contain HTML either. It's just a matter of what
words do we use. It's not that important, anyway, it was just a
suggestion.
Sergiu
--
http://purl.org/net/sergiu
------------------------------------------------------------------------
--
You receive this message as a subscriber of the xwiki-dev(a)objectweb.org mailing list.
To unsubscribe: mailto:xwiki-dev-unsubscribe@objectweb.org
For general help: mailto:sympa@objectweb.org?subject=help
ObjectWeb mailing lists service home page: http://www.objectweb.org/wws
14 Mar
14 Mar
3:58 a.m.
New subject: [xwiki-dev] Re: [xwiki-commits] r2393 - xwiki/branches/XWIKI_WYSIWYG_NEWARCHI/core/src/test/java/com/xpn/xwiki/wysiwyg
Hi all !
Now we just have began code and test for new WYSIWYG architecture.
Christian and me will optimize the code and test for Wysiwyg.
Thanks Christian for your commit !
-Phung Nam
On 3/14/07, Ludovic Dubost <ludovic(a)xwiki.com> wrote:
When checking my email on my mobile phone, I was wondering (I mostly
look at mail subjects) what Christian had done wrong to trigger these
emails after his commit !
If we manage to go at this level of details in the test code then it's
looking good ;-)
Great to see some new code for the editor !
Ludovic
Sergiu Dumitriu a écrit :
On 3/13/07, *Vincent Massol* <vincent(a)massol.net
<mailto:vincent@massol.net>> wrote:
On Mar 13, 2007, at 3:27 PM, Sergiu Dumitriu wrote:
--
Ludovic Dubost
Blog: http://www.ludovic.org/blog/
XWiki: http://www.xwiki.com
Skype: ldubost GTalk: ldubost
AIM: nvludo Yahoo: ludovic
--
You receive this message as a subscriber of the xwiki-dev(a)objectweb.orgmailing list.
To unsubscribe: mailto:xwiki-dev-unsubscribe@objectweb.org
For general help: mailto:sympa@objectweb.org?subject=help
ObjectWeb mailing lists service home page: http://www.objectweb.org/wws
Hi,
I'd say you should use lorem ipsum text, instead of real phrases.
Why? Also lorem ipsum doesn't contain HTML, does it?
-Vincent
Real phrases don't contain HTML either. It's just a matter of what
words do we use. It's not that important, anyway, it was just a
suggestion.
Sergiu
--
http://purl.org/net/sergiu
------------------------------------------------------------------------
--
You receive this message as a subscriber of the xwiki-dev(a)objectweb.orgmailing list.
To unsubscribe: mailto:xwiki-dev-unsubscribe@objectweb.org
For general help: mailto:sympa@objectweb.org?subject=help
ObjectWeb mailing lists service home page: http://www.objectweb.org/wws
5:44 a.m.
New subject: [xwiki-dev] Re: [xwiki-commits] r2393 - xwiki/branches/XWIKI_WYSIWYG_NEWARCHI/core/src/test/java/com/xpn/xwiki/wysiwyg
Chirstian! you should read Vincent's email with title "Coding Convention".
Thanks
-Phung Nam
It would be cool if all committers used the coding conventions have
defined and agreed upon. There are Eclipse and IDEA
configuration
files for them here:
http://www.xwiki.org/xwiki/bin/view/Community/CodeStyle<http://www.xwiki…
Generally speaking all committers should read everything that's on
http://www.xwiki.org/xwiki/bin/view/Community/
Feedback is welcome BTW but unless someone says something this is
what we've agreed on previously and what should be used.
Thanks
-Vincent
6449
days inactive
6450
days old
9 comments
6 participants
participants (6)
-
Catalin Hritcu -
Christian Gmeiner -
Ludovic Dubost -
Phung Nam -
Sergiu Dumitriu -
Vincent Massol