[xwiki-dev] [VOTE] Checkstyle rules (PASSED)

[Ludovic Dubost]

I suggest commiting checkstyle changes to files separately from code 
changes.
Commit first without the checkstyle changes, and a second time with it.

Otherwise we will have a hard time looking at real code changes

Ludovic

Vincent Massol a écrit :
> Ok, so we got ludovic (he hasn't answered on the list but told me verbally he's ok), Jean-Vincent, Jeremi and myself to agree on the published checkstyle rules.
>
> Nobody else has given any objection so these checkstyles rules are now our defined rules!
>
> There are some development rules that everyone has to follow now:
>
> 1) Whenever a file is clean and passes the checkstyle rules, it should be added to xwiki/trunk/core/pom.xml (or whatever module it belongs to) so that if someone make a change that breaks checkstyle the build will break and that person will have to fix the build ASAP
>
> 2) Whenever we work on new code, we must follow the defined checkstyle rules
>
> 3) From time to time it would be nice if we could spend some time fixing some existing files (like when we make changes to them).
>
> Thanks everyone.
>
> -Vincent
>
>   
>> -----Original Message-----
>> From: jeremi23 at gmail.com [mailto:jeremi23 at gmail.com] On Behalf Of
>> jeremi joslin
>> Sent: mardi 21 novembre 2006 00:25
>> To: xwiki-dev at objectweb.org
>> Subject: Re: [xwiki-dev] [VOTE] Checkstyle rules
>>
>> and mine +1
>>
>> jeremi
>>
>> On 11/18/06, Vincent Massol <vincent at massol.net> wrote:
>>     
>>> Hi,
>>>
>>> I'd like us to vote the checkstyle rules to use for XWiki. The list
>>>       
>> of
>>     
>>> rules is defined in
>>> http://tinyurl.com/yakfj7
>>>
>>> There are also Eclipse and IDEA code styles defined in
>>> http://tinyurl.com/yccrb9
>>>
>>> The idea is twofold:
>>>
>>> 1) Whenever someone cleans a file so that it passes the checkstyle
>>> rules, we make the build fail thereafter if some checkstyle violation
>>>       
>> is introduced.
>>     
>>> For example I've cleaned the ZipExplorer files and I've added them
>>>       
>> for
>>     
>>> build failure. This is done by editing the core/pom.xml file (at the
>>> end of the file).
>>>
>>> 2) Once the vote is passed, I'll apply formatting rules to the
>>> existing code.
>>>
>>> If you want to check what the code looks like after applying the
>>>       
>> rules
>>     
>>> please check the Zip Explorer files at:
>>> http://tinyurl.com/ymwvtl
>>>
>>> Here's my +1
>>>
>>> Thanks
>>> -Vincent
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>       
>> ______________________________________________________________________
>>     
>>> _____ Découvrez une nouvelle façon d'obtenir des réponses à toutes
>>>       
>> vos
>>     
>>> questions !
>>> Profitez des connaissances, des opinions et des expériences des
>>> internautes sur Yahoo! Questions/Réponses http://fr.answers.yahoo.com
>>>
>>>
>>>
>>>
>>> --
>>> You receive this message as a subscriber of the xwiki-
>>>       
>> dev at objectweb.org mailing list.
>>     
>>> To unsubscribe: mailto:xwiki-dev-unsubscribe at objectweb.org
>>> For general help: mailto:sympa at objectweb.org?subject=help
>>> ObjectWeb mailing lists service home page:
>>> http://www.objectweb.org/wws
>>>
>>>
>>>
>>>       
>> --
>> jeremi
>>     
>
>
>
>
>
>
> ___________________________________________________________________________
> D�couvrez une nouvelle fa�on d'obtenir des r�ponses � toutes vos questions !
> Profitez des connaissances, des opinions et des exp�riences des internautes sur Yahoo! Questions/R�ponses
> http://fr.answers.yahoo.com
>
>   
> ------------------------------------------------------------------------
>
>
> --
> You receive this message as a subscriber of the xwiki-dev at objectweb.org mailing list.
> To unsubscribe: mailto:xwiki-dev-unsubscribe at objectweb.org
> For general help: mailto:sympa at objectweb.org?subject=help
> ObjectWeb mailing lists service home page: http://www.objectweb.org/wws
>   


-- 
Ludovic Dubost
XPertNet: http://www.xpertnet.fr/
Blog: http://www.ludovic.org/blog/
XWiki: http://www.xwiki.com
Skype: ldubost AIM: nvludo Yahoo: ludovic