[xwiki-dev] xwiki build.434 Build Successful

[Ludovic Dubost]

Yes I know.

Currently we have in the failing tests:

ClassAdvancedTest
-> the tests are not matching the actual code behavior anymore
JCR
-> the upgrade to the new lucene library has broken the JCR implementation
All the other tests
-> failed because of Hibernate 3.2.

I looked at a first test in Util and it seems the "delete" function does 
not work properly anymore in Hibernate 3.2

Ludovic

Vincent Massol a écrit :
>   
>> -----Original Message-----
>> From: Ludovic Dubost [mailto:ludovic at xwiki.com]
>> Sent: samedi 25 novembre 2006 12:30
>> To: xwiki-dev at objectweb.org
>> Subject: Re: [xwiki-dev] xwiki build.434 Build Successful
>>
>>
>>
>> We haven't made the build fail on test results. That's all.
>>     
>
> Yes I could gather this... My real question is why not?
>
> I don't think it's good idea to allow failing tests. Tests that fail must be
> either fixed or removed if they're invalid.
>
> BTW, there were failing jcr tests and some other too before I committed the
> hibernate 3.2.0.ga version. It has added a few more failing tests. I've
> tried to fix them but haven't been able to find out the reason so far.
>
> Thanks
> -Vincent
>
>   
>> I would have liked a "warning" state but could not find how to do it.
>>
>> Ludovic
>>
>> Vincent Massol a écrit :
>>     
>>> How can the build be successful when tests are failing?
>>>
>>> Thanks
>>> -Vincent
>>>
>>>
>>>       
>>>> -----Original Message-----
>>>> From: ludovic at xwiki.org [mailto:ludovic at xwiki.org]
>>>> Sent: samedi 25 novembre 2006 11:52
>>>> To: ludovic at xwiki.org; xwiki-dev at objectweb.org
>>>> Subject: [xwiki-dev] xwiki build.434 Build Successful
>>>>
>>>> View results here ->
>>>>
>>>>         
>> http://build.xpertnet.biz/cc/buildresults/xwiki?log=log20061125112719
>>     
>>>> Lb
>>>> uild.434
>>>>
>>>>         
>>>
>>>
>>>
>>>
>>>
>>>
>>>       
>> ______________________________________________________________________
>>     
>>> _____ Yahoo! Mail réinvente le mail ! Découvrez le nouveau Yahoo!
>>>       
>> Mail
>>     
>>> et son interface révolutionnaire.
>>> http://fr.mail.yahoo.com
>>>
>>>
>>> ---------------------------------------------------------------------
>>>       
>> -
>>     
>>> --
>>>
>>>
>>> --
>>> You receive this message as a subscriber of the xwiki-
>>>       
>> dev at objectweb.org mailing list.
>>     
>>> To unsubscribe: mailto:xwiki-dev-unsubscribe at objectweb.org
>>> For general help: mailto:sympa at objectweb.org?subject=help
>>> ObjectWeb mailing lists service home page:
>>> http://www.objectweb.org/wws
>>>
>>>       
>> --
>> Ludovic Dubost
>> XPertNet: http://www.xpertnet.fr/
>> Blog: http://www.ludovic.org/blog/
>> XWiki: http://www.xwiki.com
>> Skype: ldubost AIM: nvludo Yahoo: ludovic
>>
>>     
>
>
>
>
>
>
>
> ___________________________________________________________________________
> Yahoo! Mail réinvente le mail ! Découvrez le nouveau Yahoo! Mail et son interface révolutionnaire.
> http://fr.mail.yahoo.com
>
>   
> ------------------------------------------------------------------------
>
>
> --
> You receive this message as a subscriber of the xwiki-dev at objectweb.org mailing list.
> To unsubscribe: mailto:xwiki-dev-unsubscribe at objectweb.org
> For general help: mailto:sympa at objectweb.org?subject=help
> ObjectWeb mailing lists service home page: http://www.objectweb.org/wws
>   


-- 
Ludovic Dubost
XPertNet: http://www.xpertnet.fr/
Blog: http://www.ludovic.org/blog/
XWiki: http://www.xwiki.com
Skype: ldubost AIM: nvludo Yahoo: ludovic