[xwiki-devs] [xwiki-notifications] r6377 - xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/migration/hibernate

[Sergiu Dumitriu]

Vincent Massol wrote:
> Hi Sergiu,
> 
> Shouldn't this have been a new migrator instead? Artem had a comment  
> about leaving the old XWD_ARCHIVE column in the document table. Lots  
> of users have already executed this migrator so they won't execute  
> this. So if it's important to have everyone in the same state, I think  
> a new migrator would be maybe better. But then, maybe it's not  
> important?
> 
> Thanks
> -Vincent

Indeed, for those that already ran the old migrator, it will not be 
executed again, so a new one would be needed. But I introduced this code 
in the existing migrator because the whole point was not to remove 
unused data from the deprecated column in order to reduce the space, but 
to prevent already processed archives from being processed in case the 
migrator blocks and must be restarted. So, the old archive must be 
deleted during the migration process to achieve this.


Anyway, I'll write a new migrator after I finish the Rights UI bug.

Sergiu