[xwiki-dev] [Lucene] Fixing the rebuildIndex API?

[Vincent Massol]

On Feb 2, 2007, at 12:42 PM, Ludovic Dubost wrote:

>
> +1
>
> I started rewriting the whole API leaving the older ones in  
> LucenePluginAPI as deprecated but I have to redo it all because of  
> your styling commit :(
> I'm in the process of adding the sort parameter for lucene which is  
> needed on curriki
>
> http://jira.xwiki.org/jira/browse/XWIKI-795

I have lots of other styling and other modifications. This is my way  
of taking ownership of existing code (which you asked me to do ;-)).  
I was doing this to understand the code and prepare the field for  
adding stuff from XWIKI-517 and XWIKI-757 which Jeremi asked me to  
look at.

I can put what I'm doing on hold if you want. Let me know what's best.

Thanks
-Vincent

> Vincent Massol a écrit :
>> Hi everyone,
>>
>> I can see the following API in LucenePluginAPI:
>>
>>     public int rebuildIndex(XWiki wiki, Context context)
>>
>> I can see 2 problems with that:
>>
>> 1) I don't see the need for exposing the context, especially as  
>> it's known internally by the plugin.
>> 2) Passing both the context and the wiki object seems redundant as  
>> it's possible to call context.getXWiki()
>>
>> I'm thus proposing to deprecate this method and instead replace it  
>> with:
>>
>>     public int rebuildIndex()
>>
>> Ok for everyone?
>>
>> Thanks
>> -Vincent
>>
>>
>>
>>             
>> _____________________________________________________________________ 
>> ______Yahoo! Mail réinvente le mail ! Découvrez le nouveau Yahoo!  
>> Mail et son interface révolutionnaire.
>> http://fr.mail.yahoo.com
>>
>> --------------------------------------------------------------------- 
>> ---
>>
>>
>> --
>> You receive this message as a subscriber of the xwiki- 
>> dev at objectweb.org mailing list.
>> To unsubscribe: mailto:xwiki-dev-unsubscribe at objectweb.org
>> For general help: mailto:sympa at objectweb.org?subject=help
>> ObjectWeb mailing lists service home page: http:// 
>> www.objectweb.org/wws
>>
>
>
> -- 
> Ludovic Dubost
> Blog: http://www.ludovic.org/blog/
> XWiki: http://www.xwiki.com
> Skype: ldubost GTalk: ldubost AIM: nvludo Yahoo: ludovic
>
>
>
> --
> You receive this message as a subscriber of the xwiki- 
> dev at objectweb.org mailing list.
> To unsubscribe: mailto:xwiki-dev-unsubscribe at objectweb.org
> For general help: mailto:sympa at objectweb.org?subject=help
> ObjectWeb mailing lists service home page: http://www.objectweb.org/ 
> wws






___________________________________________________________________________
Yahoo! Mail réinvente le mail ! Découvrez le nouveau Yahoo! Mail et son interface révolutionnaire.
http://fr.mail.yahoo.com