[xwiki-dev] [API] Deprecate Api.checkProgrammingRights?

[Vincent Massol]

On Feb 2, 2007, at 2:57 PM, Vincent Massol wrote:

>
> On Feb 2, 2007, at 2:47 PM, Ludovic Dubost wrote:
>
>>
>> +1
>>
>> I would also vote to deprecate Api.hasProgrammingRights in favor of
>>
>> XWiki.hasProgrammingRights()
>>
>> if it is possible.. It's not a very good idea to have these APIs  
>> in Api.. I don't know why I had this crazy idea
>
> yes, I completely agree :-) I thought it was strange too...

Let me rephrase that... I agree within the current architecture.

I really don't agree that there should be APIs for all possible stuff  
located in XWiki (i.e. flatten the object tree).

My preference would be to have components and that each component has  
a public API and that API be available from velocity or groovy. We  
are already stretching the XWiki object too much. Thus any rights  
check should be done through the Rights manager component.

Something like:

$container.lookup 
("com.xpn.xwiki....RightsManager").hasProgrammingRights()

Of course we could register some well known components:

$rightsManager.hasProgrammingRights()

In Java:

public class MyClassRequiringRightsVerifications ...
{
     private RightsManager;
...
}

Then MyClassRequiringRightsVerifications is registered againt the  
component manager (Plexus, OSGi, etc) with a dependency on the  
RightsManager component so that it's injected either in the  
constructor, in setters or in the field.

This is what I'd like to do for XWiki 2.0.

Thanks
-Vincent

>
> Let's do it in 2 steps as the second refactoring might be more  
> complex (I'll look into it).
>
> Thanks
> -Vincent
>
>> Jean-Vincent Drean a écrit :
>>> +1
>>>
>>> 2007/2/2, Vincent Massol <vincent at massol.net>:
>>>> Hi,
>>>>
>>>> I'd like to deprecate Api.checkProgrammingRights() in favor of
>>>> Api.hasProgrammingRights(). It's not normal that we have 2 APIs for
>>>> doing the same thing and none of them being deprecated.
>>>>
>>>> Is that ok for everyone?
>>>>
>>>> Thanks
>>>> -Vincent
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> ___________________________________________________________________ 
>>>> ________
>>>> Yahoo! Mail réinvente le mail ! Découvrez le nouveau Yahoo! Mail  
>>>> et son interface révolutionnaire.
>>>> http://fr.mail.yahoo.com
>>>>
>>>>
>>>>
>>>>
>>>> -- 
>>>> You receive this message as a subscriber of the xwiki- 
>>>> dev at objectweb.org mailing list.
>>>> To unsubscribe: mailto:xwiki-dev-unsubscribe at objectweb.org
>>>> For general help: mailto:sympa at objectweb.org?subject=help
>>>> ObjectWeb mailing lists service home page: http:// 
>>>> www.objectweb.org/wws
>>>>
>>>>
>>>>
>>>
>>> -------------------------------------------------------------------- 
>>> ----
>>>
>>>
>>> --
>>> You receive this message as a subscriber of the xwiki- 
>>> dev at objectweb.org mailing list.
>>> To unsubscribe: mailto:xwiki-dev-unsubscribe at objectweb.org
>>> For general help: mailto:sympa at objectweb.org?subject=help
>>> ObjectWeb mailing lists service home page: http:// 
>>> www.objectweb.org/wws
>>>
>>
>>
>> -- 
>> Ludovic Dubost
>> Blog: http://www.ludovic.org/blog/
>> XWiki: http://www.xwiki.com
>> Skype: ldubost GTalk: ldubost AIM: nvludo Yahoo: ludovic
>>
>>
>>
>> --
>> You receive this message as a subscriber of the xwiki- 
>> dev at objectweb.org mailing list.
>> To unsubscribe: mailto:xwiki-dev-unsubscribe at objectweb.org
>> For general help: mailto:sympa at objectweb.org?subject=help
>> ObjectWeb mailing lists service home page: http:// 
>> www.objectweb.org/wws
>
>
>
>
>
>
> ______________________________________________________________________ 
> _____
> Yahoo! Mail réinvente le mail ! Découvrez le nouveau Yahoo! Mail et  
> son interface révolutionnaire.
> http://fr.mail.yahoo.com
>
>
> --
> You receive this message as a subscriber of the xwiki- 
> dev at objectweb.org mailing list.
> To unsubscribe: mailto:xwiki-dev-unsubscribe at objectweb.org
> For general help: mailto:sympa at objectweb.org?subject=help
> ObjectWeb mailing lists service home page: http://www.objectweb.org/ 
> wws






___________________________________________________________________________
Yahoo! Mail réinvente le mail ! Découvrez le nouveau Yahoo! Mail et son interface révolutionnaire.
http://fr.mail.yahoo.com