[xwiki-dev] [API] New Api.getContext() method?

[Vincent Massol]

On Feb 2, 2007, at 10:14 PM, Vincent Massol wrote:

>
> On Feb 2, 2007, at 9:55 PM, Vincent Massol wrote:
>
>>
>> On Feb 2, 2007, at 9:43 PM, Sergiu Dumitriu wrote:
>>
>>> I think you should reconsider this, if I understood things  
>>> correctly.
>>>
>>> Api.getContext is a method that can be called from any velocity  
>>> code, and the XWikiContext class should NOT be freely available.
>>
>> Right. Ok, so what you're saying is that getContext should be  
>> protected instead of public?
>>
>> I thought about this before implementing it but then the Api  
>> constructor is public and takes a XWikiContext object. Thus I  
>> guess what we are really saying is that either we should use  
>> Context instead of XWikiContext and leave everything public or  
>> make the constructor and the getContext method protected.
>
> I think the protected solution is the best for now (it certainly is  
> the easiest).

Fixed. I didn't put the constructor protected as this would have  
caused an issue (the XWikiDocument.newDocument wouldn't have been  
able to create a Document object).

-Vincent

	

	
		
___________________________________________________________________________ 
Yahoo! Mail réinvente le mail ! Découvrez le nouveau Yahoo! Mail et son interface révolutionnaire.
http://fr.mail.yahoo.com