[xwiki-commits] r4023 - xwiki-products/xwiki-enterprise/trunk/distribution-test/src/test/it/com/xpn/xwiki/it

[Vincent Massol]

Hi Catalin,

On Jul 25, 2007, at 12:25 PM, Catalin Hritcu wrote:

> Author: hritcu
> Date: 2007-07-25 12:25:45 +0200 (Wed, 25 Jul 2007)
> New Revision: 4023
>
> Modified:
>    xwiki-products/xwiki-enterprise/trunk/distribution-test/src/test/ 
> it/com/xpn/xwiki/it/DeletePageTest.java
> Log:
> Test for the presence of bug XWIKI-1388 (the test currently fails)
>
> Modified: xwiki-products/xwiki-enterprise/trunk/distribution-test/ 
> src/test/it/com/xpn/xwiki/it/DeletePageTest.java
> ===================================================================
> --- xwiki-products/xwiki-enterprise/trunk/distribution-test/src/ 
> test/it/com/xpn/xwiki/it/DeletePageTest.java	2007-07-25 08:45:50  
> UTC (rev 4022)
> +++ xwiki-products/xwiki-enterprise/trunk/distribution-test/src/ 
> test/it/com/xpn/xwiki/it/DeletePageTest.java	2007-07-25 10:25:45  
> UTC (rev 4023)
> @@ -109,6 +109,18 @@
>          }
>      }
>
> +    /*
> +     * This tests for regression of XWIKI-1388
> +     */

This should be a javadoc I think.

> +    public void testUserStaysLoggedInWhileDeleting()
> +    {
> +        logInAndCreatePageToBeDeleted("DeleteTest");
> +        clickDeletePage();
> +
> +        assertTrue("The interface should not show the user as  
> logged out while deleting",
> +                isAuthenticated());
> +    }
> +

I don't think we should commit test that make the build fail. We  
should commit them at the same time as we commit the fix IMO. When  
you don't have the implementation ready, then I suggest putting them  
in the JIRA issue related to the problem. That's what I did in the past.

WDYT?

Thanks
-Vincent