[xwiki-dev] [Opinions needed] Encoding of xwiki source files

[Vincent Massol]

On Mar 10, 2007, at 7:24 PM, Sébastien Gaïde wrote:

> Vincent Massol a écrit :
>> +1 option 2 too (I think option 1 is never going to work because  
>> it's too constraining for developers).
>
> why ?

Because every committer has to make a conscious effort of setting up  
all his editors to save in utf8 (vi, idea, emacs, etc) and you can be  
sure some will not do it, by mistake, etc.

Look at the rules in the development guide on xwiki.org. They are  
pretty simple rules but almost nobody uses them...

So if we prefer to be safe rather than sorry I think a solution that  
doesn't mandate some voluntary effort is better.

I may be wrong of course :)

-Vincent

>
> XWiki is the only project that is not encoded in utf8 in my workspace.
> All the other projects are 100% utf8, with no problem.
>
> S.
>
>> -Vincent
>> On Mar 8, 2007, at 4:01 PM, Gilles Serasset wrote:
>>> Hi all,
>>>
>>> While working on encodings problems, I saw that some of the  
>>> source file do use non ascii chars (which is normal, especially  
>>> in unit tests).
>>>
>>> But, there is currently no decision on the encoding of the source  
>>> file, hence, compilers cannot correctly read the files that do  
>>> use non ascii chars. This leads to tests working on single  
>>> instances but not on others, only due to compilation settings.
>>>
>>> There are 2 solutions:
>>>
>>> 1. force everybody to use UTF-8 encoding for their source files  
>>> (it's quite easy to st up most IDE once and for all for this...)  
>>> and specify the encoding in javac parameters in ant and maven.
>>> 2. force everybody to use unicode escapes (\uXXXX) to specify a  
>>> non ascii char in the sources (easily detectable on build, but  
>>> harder for developpers who have to use native2ascii)
>>>
>>> Current files with non ascii chars:
>>> /Users/serasset/dev/xwiki/trunks-users/xwiki/core/src/main/java/ 
>>> com/xpn/xwiki/plugin/autotag/FrenchStemmer.java
>>> /Users/serasset/dev/xwiki/trunks-users/xwiki/core/src/main/java/ 
>>> com/xpn/xwiki/plugin/autotag/AutoTagPlugin.java
>>> (Both are in ISO-8859-1)
>>> /Users/serasset/dev/xwiki/trunks-users/xwiki/core/src/test/java/ 
>>> com/xpn/xwiki/content/LinkTest.java
>>> (this one seems to be encoded in VISCII (vietnamese encoding)
>>>
>>> As in LinkTest.java, the test uses vietnamese characters, it's  
>>> likely that ISO-8859-1 encoding is not a viable option for the  
>>> xwiki source encoding. In the mean time, LinkTest.java should use  
>>> \uXXXX uniocde escapes in order to run correctly in all installs.
>>>
>>> Can you please tell me which solution you prefer ?
>>>
>>> Regards,
>>>
>>> -- 
>>> Gilles Sérasset
>>> GETALP-LIG
>>> BP 53 - F-38041 Grenoble Cedex 9
>>> Phone: +33 4 76 51 43 80
>>> Fax:   +33 4 76 44 66 75
>>>
>>>
>>>
>>>
>>>
>>> -- 
>>> You receive this message as a subscriber of the xwiki- 
>>> dev at objectweb.org mailing list.
>>> To unsubscribe: mailto:xwiki-dev-unsubscribe at objectweb.org
>>> For general help: mailto:sympa at objectweb.org?subject=help
>>> ObjectWeb mailing lists service home page: http:// 
>>> www.objectweb.org/wws
>
>
>
> --
> You receive this message as a subscriber of the xwiki- 
> dev at objectweb.org mailing list.
> To unsubscribe: mailto:xwiki-dev-unsubscribe at objectweb.org
> For general help: mailto:sympa at objectweb.org?subject=help
> ObjectWeb mailing lists service home page: http://www.objectweb.org/ 
> wws