[xwiki-dev] Problem with new comment on save feature

[Vincent Massol]

On May 9, 2007, at 10:23 AM, Ludovic Dubost wrote:

>
> Hi,
>
> These behavior are user configurable.. Maybe I did not put the  
> right default config in xwiki.cfg
> With this config you are non intrusive..

ok I've changed the default to be less intrusive by default.

> ## Use edit comments (activate/deactivate the whole feature)
> xwiki.editcomment=1
> ## Hide editcomment field and only use JS (show/hide the field. 1  
> is hidden)
> xwiki.editcomment.hidden=0
> ## Make edit comment mandatory (asks until the comment is not  
> empty. 1 is mandatory. 0 means comment can be empty)
> xwiki.editcomment.mandatory=0

In that case the popup shouldn't have a cancel button I think as it's  
misleading. WDYT?

> ## Make edit comment suggested (asks 1 time if the comment is  
> empty. 1 shows one popup if comment is empty. 0 means there is no  
> popup. This setting is ignored is mandatory is set)
> xwiki.editcomment.suggested=0

Thanks
-Vincent

> Vincent Massol a écrit :
>> Hi,
>>
>> 1) In trunk, it's not possible to save without entering a comment.  
>> I think this should be optional.
>> 2) When clicking on save with no comment there's a dialog box that  
>> pops up that asks for a comment but it's not possible to cancel it  
>> even though there's a cancel button
>>
>> Thanks
>> -Vincent