[xwiki-devs] [Fwd: Re: [xwiki-notifications] r8905 - xwiki-platform/core/branches/xwiki-core-1.3/xwiki-core/src/main/resources/META-INF/services]

[Sergiu Dumitriu]

Forwarding to the proper mailing list.

-------- Original Message --------
Subject: Re: [xwiki-notifications] r8905 - 
xwiki-platform/core/branches/xwiki-core-1.3/xwiki-core/src/main/resources/META-INF/services
Date: Tue, 1 Apr 2008 22:24:01 +0200
From: Vincent Massol <vincent at massol.net>
Reply-To: XWiki Notifications <notifications at xwiki.org>
To: XWiki Notifications <notifications at xwiki.org>
References: <20080401193540.8E8996C0A93 at vsvn.xpertnet.biz>

Hi Ludovic,

This needs to be commented in the code to explain why we're commenting
out the EscapeFilter.

Thanks
-Vincent

PS: I spent lots of time (> 8 hours) fixing my Velocity code because a
very tricky code was done in the old XWikiVelocityRenderer code with
NO comments at all. We need to really start improving the quality of
our code and we need everyone's help. That'll save us from a lot of
trouble in the future.

On Apr 1, 2008, at 9:35 PM, ludovic (SVN) wrote:

> Author: ludovic
> Date: 2008-04-01 21:35:40 +0200 (Tue, 01 Apr 2008)
> New Revision: 8905
>
> Modified:
>   xwiki-platform/core/branches/xwiki-core-1.3/xwiki-core/src/main/ 
> resources/META-INF/services/com.xpn.xwiki.render.filter.XWikiFilter
> Log:
> XWIKI-2269 \\ in wiki syntax does not convert to 2 <br /> but  
> instead escaped one \ in HTML
>
> Modified: xwiki-platform/core/branches/xwiki-core-1.3/xwiki-core/src/ 
> main/resources/META-INF/services/ 
> com.xpn.xwiki.render.filter.XWikiFilter
> ===================================================================
> --- xwiki-platform/core/branches/xwiki-core-1.3/xwiki-core/src/main/ 
> resources/META-INF/services/com.xpn.xwiki.render.filter.XWikiFilter	 
> 2008-04-01 19:32:54 UTC (rev 8904)
> +++ xwiki-platform/core/branches/xwiki-core-1.3/xwiki-core/src/main/ 
> resources/META-INF/services/com.xpn.xwiki.render.filter.XWikiFilter	 
> 2008-04-01 19:35:40 UTC (rev 8905)
> @@ -2,7 +2,7 @@
> # The content is restored later on in the CodeRestoreFilter. The  
> filter has to be executed first
> # to ensure no modifications is done to the content.
> com.xpn.xwiki.render.filter.CodeRemoveFilter
> -com.xpn.xwiki.render.filter.EscapeFilter
> +#com.xpn.xwiki.render.filter.EscapeFilter
> org.radeox.filter.ParamFilter
> com.xpn.xwiki.render.filter.StyleFilter
> com.xpn.xwiki.render.filter.MacroFilter

_______________________________________________
notifications mailing list
notifications at xwiki.org
http://lists.xwiki.org/mailman/listinfo/notifications


-- 
Sergiu Dumitriu
http://purl.org/net/sergiu/