[xwiki-devs] [GSOC] Can't commit to sandbox

[Fabio Mancinelli]

On 17 juin 08, at 14:15, malaka ekanayake wrote:

> Hi fabio
>
> I tried with both ways but getting the same error.Anyway  I'll try  
> it again.In my previous  mail I have attached my sample plugin.Can  
> you look at that one till I fix this issur and commit to the  
> sandbox.svn root will be fine.I'll commit to that  path.

Hi Malaka,

I've looked at your code and you did a good job!
It works pretty well though there are some things that must be  
improved (like the ones you were mentioning)

Before I commit the code, could you please, do a bit of reformatting?
Here at http://svn.xwiki.org/svnroot/xwiki/xwiki-platform/xwiki-tools/trunk/xwiki-verification-resources/src/main/resources/ 
  you can find the .xml for the Eclipse formatter. This style is the  
style used by XWiki.

I saw that that in your code there are some classes that probably are  
useless (is the TagRule used?) Could you please remove all the unused  
code inorder to avoid confusion?

I also noticed that you incorporated verbatim some code from the  
tutorial (the tutorial's author name is in your code)
Be careful when incorporating third party code. You must always check  
for licenses and compatibility and authorization!!!
Ideally you should write all the code by yourself, even if when you  
use a framework you end up with writing more or less the same code.
Could you check that the tutorial's code can be reused without  
restrictions?

Please, keep the conversations on the XWiki devs list so that  
everybody can follow it.

Send me a zip with the modifications and I'll commit it to the sandbox.

After that, it's important to address Vincent's parser integration and  
spend some time on trying to figure out if and how it can be  
integrated in your work. I guess that Vincent's parser should be used  
as the partitioner, with it's output definining document's partition.  
But this has to be well investigated because it might be not so simple.

Let me know.

Cheers,
Fabio