[xwiki-devs] [GSOC] sample xwiki syntax coloring plugin commited to the sandbox

[Vincent Massol]

Hi Malaka,

On Jun 24, 2008, at 10:41 PM, malaka ekanayake wrote:

> Hi all
>
> see my comments below
>
> On Tue, Jun 24, 2008 at 11:50 PM, Vincent Massol  
> <vincent at massol.net> wrote:
>
>>
>> On Jun 24, 2008, at 11:53 AM, Venkatesh Nandakumar wrote:
>>
>>> Hi Fabio, Malaka,
>>>
>>> After my discussion with Stephane, we've decided that Malaka should
>>> continue with improving the core editor as such..
>>> That is, better syntax highlighting and stuff..
>>>
>>> I've implemented a bit of ContentOutline Page, (that shows the  
>>> overall
>>> view of the page, like titles, paragraphs overview etc), as a
>>> TreeViewer implementation.
>>>
>>> For now, I'll try to integrate the present editor with xeclipse
>>> extension. Then, I'd try to introduce wikimodel support, that is,
>>> conversion of one syntax to another syntax. For this, I think we'll
>>> have to code editors for all other syntaxes too, since after
>>> conversion, we'll have to support editing in that syntax.. right??
>>
>> No please don't do this! This is exactly what I have written in the
>> new rendering module. I'd like that both Malaka and you spend some
>> time understanding the new rendering module. Please ask as many
>> questions as you want here since it's not currently well documented
>> but please don't reinvent the wheel.
>
>
> I have looked at the parser and rendering api. I think we can  
> integrate with
> the jface editor in the following way
>
> We can extract blocks from the  XDOM object created by the  
> parser.Then if we
> can find a way to map these blocks with non overlapping partitions  
> defined
> in the jface,then it seems like we can integrate both.As I have  
> realised
> partitions need the offset and the length with respect to the xwiki
> document.I think we need to add 2 methods to the Block inteface to  
> get the
> offset and the length.
>
> According to my current undestanding we need to impliment the
> IDocumentPartitioner inteface and use the excisting xwiki parser in  
> thet
> implimentation.The main perpose of the implimentation is to map the  
> blocks
> in to partitions.
>
> please give  your  comments on this

Sounds good. I've skimmed very quickly through http://www.realsolve.co.uk/site/tech/jface-text.php 
  and this is my understanding too. Some open questions/remarks/ 
comments I have:

* What I'm not sure yet (since I haven't read that far ;)) is how you  
plug the IDocumentPartitioner to the syntax highlighting.
* XDOM is a tree, i.e. Blocks are nested. Are the partitions nested too?
* Re the offset and lengthn I think this is something interesting that  
could be added to the new rendering module. Since the underlying  
parsers (wikimodel, doxia) don't pass this information to us we would  
need to compute it. It would allow us to answer the question "what  
block is located at location NN in the source document".
* We need to get Marius'  input since he's working on the new WYSIWYG  
editor for XWiki and maybe he has some similar needs/issues.

Also I see that JFace has lots of existing rule-based APIs to simply  
parsing/scanning (a la http://jparsec.codehaus.org/) so I'm still  
unsure if we can plug the rendering parser in a natural manner.

I don't know JFace at all so some advice from someone who knows it  
would be nice.

Thanks
-Vincent

>> Also I'd like to know if the new
>> rendering API is missing anything you'd need for your use cass.
>>
>> Thanks
>> -Vincent
>>
>>> Then I'll be doing more advanced content assist, proposal, i.e, give
>>> the user the list of pages that can be linked, as a contest assist
>>> proposal, using the rpc api of xwiki..
>>>
>>> Cheers,
>>> Venkatesh
>>>
>>>
>>> On Thu, Jun 19, 2008 at 14:36, Venkatesh Nandakumar
>>> <venkatesh88 at gmail.com> wrote:
>>>> Hi,
>>>>
>>>> I've uploaded my project to
>>>> http://svn.xwiki.org/svnroot/sandbox/org.xwiki.eclipse.plugin/ ,
>>>> please go through the Sample.xwiki file.
>>>> Malaka can go through the code, and implement the extra features to
>>>> this.
>>>>
>>>> Cheers,
>>>> Venkatesh
>>>>
>>>> On Thu, Jun 19, 2008 at 10:34, Vincent Massol <vincent at massol.net>
>>>> wrote:
>>>>>
>>>>> On Jun 19, 2008, at 10:09 AM, Venkatesh Nandakumar wrote:
>>>>>
>>>>> [snip]
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I just saw Malaka's code now. I'm actually merging my code to his
>>>>>> now,
>>>>>> seems I don't have the committing rights to sandbox as of yet.
>>>>>>
>>>>>> Mr Vincent, please give the appropriate rights to my id vnkatesh
>>>>>
>>>>> Done.
>>>>>
>>>>> Thanks
>>>>> -Vincent